Repository navigation
Python: fix(python): set Mistral metadata usage to CompletionUsage instead of tuple - #14629
Open
Hardik K (hardikkaurani) wants to merge 1 commit into
Open
Hardik K (hardikkaurani) wants to merge 1 commit into
Hardik K (hardikkaurani) wants to merge 1 commit into
Conversation
Hardik K (hardikkaurani)
deployed
to
github-app-auth
October 19, 2026 20:08 — with
GitHub Actions
Active
Hardik K (hardikkaurani)
deployed
to
github-app-auth
October 19, 2026 20:08 — with
GitHub Actions
Active
Author
|
Hi Vincent Biret (@baywet) Eduard van Valkenburg (@eavanvalkenburg), opened this PR to fix #14617 where |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #14617
In the Python
MistralAIChatCompletionconnector,metadata["usage"]was being set to a 1-tuple(CompletionUsage(...),)instead ofCompletionUsage(...)due to a trailing comma inmistral_ai_chat_completion.py.Because of this:
isinstance(usage, CompletionUsage), which evaluates toFalsefor a tuple, silently omittinggen_ai.usage.input_tokensandgen_ai.usage.output_tokensfrom telemetry spans.result.metadata["usage"].prompt_tokensencounterAttributeError: 'tuple' object has no attribute 'prompt_tokens'.Description
_get_metadata_from_responsewithinMistralAIChatCompletionsometadata["usage"]is assignedCompletionUsage.test_get_chat_message_contentsverifying thatmetadata["usage"]is an instance ofCompletionUsagewith expected token counts.Fixes #14617
cc Vincent Biret (@baywet) Eduard van Valkenburg (@eavanvalkenburg)