Skip to content

.Net: Add TextPlugin unit tests for culture and Echo - #14587

Open
Shinoj Manikkoth mundayadan (shinojmm) wants to merge 2 commits into
microsoft:mainfrom
shinojmm:textplugin-unit-tests
Open

Shinoj Manikkoth mundayadan (shinojmm) wants to merge 2 commits into
microsoft:mainfrom
shinojmm:textplugin-unit-tests

Conversation

@shinojmm

Copy link
Copy Markdown

Motivation and Context

TextPlugin had no tests for the cultureInfo parameter of Uppercase/Lowercase, and Echo had no tests at all.

Description

  • Added tests for Uppercase and Lowercase with a specific culture (tr-TR).
  • Added a theory test for Echo.
  • Test-only change, no production code modified.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the SK Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • I didn't break anyone 😄

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused test additions correctly validate existing behavior with no unresolved issues.

0 open findings

What changed in this PR

Adds missing TextPlugin unit coverage for culture-aware casing and echo behavior.

Changes:

  • Tests Turkish uppercase and lowercase rules.
  • Adds parameterized tests for Echo.
File Description
dotnet/​src/​Plugins/​Plugins.UnitTests/​Core/​TextPluginTests.cs Adds culture-specific casing and echo tests.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@shinojmm

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@shinojmm

Copy link
Copy Markdown
Author

Shinoj Manikkoth mundayadan (Shinoj Manikkoth mundayadan (@shinojmm)) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

This branch was previously deployed

1 inactive deployment
github-app-auth — f0154d1a Deployed Oct 13, 2026 by shinojmm via add_label #29332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants