Repository navigation
.Net: Add TextPlugin unit tests for culture and Echo - #14587
Open
Shinoj Manikkoth mundayadan (shinojmm) wants to merge 2 commits into
Open
Shinoj Manikkoth mundayadan (shinojmm) wants to merge 2 commits into
Shinoj Manikkoth mundayadan (shinojmm) wants to merge 2 commits into
Conversation
Shinoj Manikkoth mundayadan (shinojmm)
requested a review
from a team
as a code owner
October 13, 2026 16:22
Shinoj Manikkoth mundayadan (shinojmm)
temporarily deployed
to
github-app-auth
October 13, 2026 16:22 — with
GitHub Actions
Inactive
Shinoj Manikkoth mundayadan (shinojmm)
temporarily deployed
to
github-app-auth
October 13, 2026 16:22 — with
GitHub Actions
Inactive
Copilot started reviewing on behalf of
Shinoj Manikkoth mundayadan (shinojmm)
October 13, 2026 16:23
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test additions correctly validate existing behavior with no unresolved issues.
0 open findings
What changed in this PR
Adds missing TextPlugin unit coverage for culture-aware casing and echo behavior.
Changes:
- Tests Turkish uppercase and lowercase rules.
- Adds parameterized tests for
Echo.
| File | Description |
|---|---|
dotnet/src/Plugins/Plugins.UnitTests/Core/TextPluginTests.cs |
Adds culture-specific casing and echo tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Shinoj Manikkoth mundayadan (shinojmm)
temporarily deployed
to
github-app-auth
October 13, 2026 16:24 — with
GitHub Actions
Inactive
Author
|
@microsoft-github-policy-service agree |
Author
@microsoft-github-policy-service agree |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
TextPluginhad no tests for thecultureInfoparameter ofUppercase/Lowercase, andEchohad no tests at all.Description
UppercaseandLowercasewith a specific culture (tr-TR).Echo.Contribution Checklist