Repository navigation
Python: fix(functions): validate complex kernel function arguments - #14466
Open
Adil Alperen Çiftci (adilalperenciftci) wants to merge 4 commits into
Open
Adil Alperen Çiftci (adilalperenciftci) wants to merge 4 commits into
Adil Alperen Çiftci (adilalperenciftci) wants to merge 4 commits into
Conversation
Complex and Union annotations containing commas could bypass parameter parsing in gather_function_parameters, allowing raw argument values to reach the kernel function. Validate generic annotations with Pydantic TypeAdapter and remove the condition that skipped parsing for comma-containing type metadata.
Adil Alperen Çiftci (adilalperenciftci)
requested a review
from a team
as a code owner
September 21, 2026 06:49
Adil Alperen Çiftci (adilalperenciftci)
had a problem deploying
to
github-app-auth
September 21, 2026 06:49 — with
GitHub Actions
Failure
Adil Alperen Çiftci (adilalperenciftci)
had a problem deploying
to
github-app-auth
September 21, 2026 06:49 — with
GitHub Actions
Failure
Adil Alperen Çiftci (adilalperenciftci)
had a problem deploying
to
github-app-auth
September 21, 2026 07:00 — with
GitHub Actions
Failure
… empty Preserve PEP 604 and typing.Union type metadata during kernel function parameter inspection when unions do not contain NoneType.
Adil Alperen Çiftci (adilalperenciftci)
temporarily deployed
to
github-app-auth
October 10, 2026 09:33 — with
GitHub Actions
Inactive
Signed-off-by: Adil Alperen Çiftci <adilerta54@gmail.com>
Adil Alperen Çiftci (adilalperenciftci)
temporarily deployed
to
github-app-auth
October 20, 2026 11:25 — with
GitHub Actions
Inactive
Author
|
Updated the branch to current |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complex and Union annotations containing commas could bypass parameter parsing in
gather_function_parameters, allowing raw argument values to reach the kernel function.Changes
TypeAdapter."," not in param.type_that skipped parsing for comma-containing type metadata.