Skip to content

Python: Cover callable and mixed Postgres search filters #14313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tgolob wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Python: Cover callable and mixed Postgres search filters #14313

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f610b9
fix(postgres): compose vector filters as SQL
tgolob Aug 22, 2026
4ce846f
Merge branch 'main' into fix/postgres-filter-sql
eavanvalkenburg Sep 28, 2026
aeb9c2b
Merge main and refresh Postgres filter regression coverage
tgolob Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions python/tests/unit/connectors/memory/test_postgres_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import ast
import asyncio
from collections.abc import AsyncGenerator
from collections.abc import AsyncGenerator, Callable
from dataclasses import dataclass
from typing import Annotated, Any
from unittest.mock import AsyncMock, MagicMock, Mock, patch
Expand Down Expand Up @@ -248,12 +248,32 @@ async def test_get_records(vector_store: PostgresStore, mock_cursor: Mock) -> No
"filter, filter_sql, filter_params",
[
(None, "", []),
([], "", []),
("lambda x: x.id == 1", ' WHERE ("id" = %s)', [1]),
(lambda x: x.id == 1, ' WHERE ("id" = %s)', [1]),
(["lambda x: x.id == 1"], ' WHERE ("id" = %s)', [1]),
([lambda x: x.id == 1], ' WHERE ("id" = %s)', [1]),
(
["lambda x: x.id > 0", "lambda x: x.id == 1 or x.id == 2"],
' WHERE ("id" > %s) AND (("id" = %s OR "id" = %s))',
[0, 1, 2],
),
(
[
lambda x: x.id > 0,
lambda x: x.id == 1 or x.id == 2,
],
' WHERE ("id" > %s) AND (("id" = %s OR "id" = %s))',
[0, 1, 2],
),
(
[
"lambda x: x.id > 0",
lambda x: x.id == 1 or x.id == 2,
],
' WHERE ("id" > %s) AND (("id" = %s OR "id" = %s))',
[0, 1, 2],
),
],
)
@pytest.mark.parametrize(
Expand All @@ -274,7 +294,7 @@ async def test_vector_search(
subquery_distance: str | None,
include_vectors: bool,
include_total_count: bool,
filter: str | list[str] | None,
filter: str | Callable | list[str | Callable] | None,
filter_sql: str,
filter_params: list[Any],
) -> None:
Expand Down
Loading