Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python: Add User-Agent header for Anthropic API calls #13579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Python: Add User-Agent header for Anthropic API calls #13579
Changes from all commits
d5b1eb7293208e6c881fbFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dict(copy(default_headers))is redundant —dict(default_headers)already produces a new dict from anyMapping. Thecopy()call (and the import) can be removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged_headersis computed (including APP_INFO injection) for every call, but is only consumed in theif not async_clientbranch. When a caller passes a pre-builtasync_client,default_headersis silently discarded. Either emit alogger.warninghere when both are provided, or raise early.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test only covers
APP_INFO=Nonewithout custom headers. Consider adding sibling tests for: (1)default_headers={"X-Custom": "value"}withAPP_INFO=Noneto verify custom headers are still forwarded, and (2) bothasync_clientanddefault_headersprovided to document the expected behavior (warning, error, or documented no-op).Uh oh!
There was an error while loading. Please reload this page.