docs(worker): improve JSDoc and strengthen error handling - #5320
Closed
Kushal Meghani (KushalMeghani1644) wants to merge 8 commits into
Closed
docs(worker): improve JSDoc and strengthen error handling#5320Kushal Meghani (KushalMeghani1644) wants to merge 8 commits into
Kushal Meghani (KushalMeghani1644) wants to merge 8 commits into
Conversation
- Added detailed JSDoc comments for better clarity and maintainability - Narrowed to properly handle Error vs non-Error cases - Removed unused field from ILocalTimeInfo
Author
|
@microsoft-github-policy-service agree |
Member
|
You're missing a changelog entry. Can you run |
Author
|
Hey Ian Clanton-Thuon (@iclanton) I have added the changelog file as you requested. |
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
…8-09-31.json Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Author
|
Ian Clanton-Thuon (@iclanton) I removed the explicit type since TypeScript can infer that |
Kushal Meghani (KushalMeghani1644)
requested a review
from Ian Clanton-Thuon (iclanton)
September 5, 2025 07:00
… init loop consolidated error handling, typed MessafePort alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs(worker): improve JSDoc and error handling in cpu-profile-summarizer