[rush] Optimize setPreferredVersions - #5312
Merged
David Michon (dmichon-msft) merged 4 commits intoAug 22, 2025
Merged
David Michon (dmichon-msft) merged 4 commits into
David Michon (dmichon-msft) merged 4 commits into
Conversation
David Michon (dmichon-msft)
requested a review
from Ian Clanton-Thuon (iclanton)
as a code owner
August 20, 2025 02:27
David Michon (dmichon-msft)
requested review from
Daniel (D4N14L),
Apostolis Haitalis (apostolisms) and
Pete Gonzalez (octogonz)
as code owners
August 20, 2025 02:27
Bharat Middha (bmiddha)
approved these changes
Aug 20, 2025
Daniel (D4N14L)
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes the
setPreferredVersionshelper function that applies thepreferredVersionsinformation fromcommon-versions.jsonto packages.Details
Avoids unnecessary range parsing for values that contain protocol specifiers, as they are not valid SemVer range specifiers. Caches range parsing results and ensures that the parsed values are used as-is by the
subsetfunction.Avoids processing of the
devDependenciesfield for anypackage.jsonthat is not part of the workspace.How it was tested
Before:
After:
Impacted documentation
None.