[heft-swc] Reduce set of watched folders - #5295
Merged
David Michon (dmichon-msft) merged 3 commits intoAug 4, 2025
Merged
Conversation
David Michon (dmichon-msft)
requested a review
from Ian Clanton-Thuon (iclanton)
as a code owner
August 4, 2025 20:43
David Michon (dmichon-msft)
requested review from
Daniel (D4N14L),
Apostolis Haitalis (apostolisms) and
Pete Gonzalez (octogonz)
as code owners
August 4, 2025 20:43
Ian Clanton-Thuon (iclanton)
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the watch logic to only watch folders that TypeScript has identified has having wildcard patterns for source files, rather than all folders enumerated during TSConfig parsing.
This avoids, for example, watching for changes to the project root folder.
Details
The TSConfig parser returns a
wildcardDirectoriesobject that indicates folders that contained wildcards and if the wildcard is local (*or?) or recursive (**). This is used to determine the directories that should be watched by Heft's watcher.How it was tested
Local
heft run-watch --only build -- --cleaninheft-swc-testand creating/modifying/deleting files at various points in the directory hierarchy.Linked the new version into a repository that was having infinite loop issues and verified that no such issues occur.
Impacted documentation
None.