Skip to content

Test build again - #2617

Closed
Ilya Matiach (imatiach-msft) wants to merge 1 commit into
mainfrom
ilmat/test-build-from-branch-again
Closed

Test build again#2617
Ilya Matiach (imatiach-msft) wants to merge 1 commit into
mainfrom
ilmat/test-build-from-branch-again

Conversation

@imatiach-msft

Copy link
Copy Markdown
Collaborator

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates a packaging-related comment in responsibleai/setup.py, intended to clarify where the package version is sourced during build/install.

Changes:

  • Adjusted the inline comment describing how the package version is determined.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread responsibleai/setup.py
import setuptools

# Version will be read from version.py
# Version will be read from version.py file

Copilot AI Mar 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says the version is read from version.py, but the code below actually reads from responsibleai/__version__.py (via os.path.join(name, '__version__.py')). Please update the comment to match the real source to avoid confusion for maintainers.

Suggested change
# Version will be read from version.py file
# Version will be read from responsibleai/__version__.py file

Copilot uses AI. Check for mistakes.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.18%. Comparing base (8c219cb) to head (de11798).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2617   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          18       18           
  Lines        1278     1278           
=======================================
  Hits          897      897           
  Misses        381      381           
Flag Coverage Δ
unittests 70.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants