Repository navigation
Prevent undefined values from entering RVM sets - #841
Merged
Anand Krishnamoorthi (anakrish) merged 1 commit intoOct 16, 2026
Merged
Anand Krishnamoorthi (anakrish) merged 1 commit into
Anand Krishnamoorthi (anakrish) merged 1 commit into
Conversation
Co-authored-by: anakrish <35780660+anakrish@users.noreply.github.com>
Copilot
AI
changed the title
fix(rvm): omit undefined set emissions (standalone prerequisite for #835)
Prevent undefined values from entering RVM sets
Oct 15, 2026
Anand Krishnamoorthi (anakrish)
approved these changes
Oct 16, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused guards preserve validation and defined values, with relevant regression coverage and no blocking findings; tests were not executed.
0 open findings
What changed in this PR
Fixes RVM set accumulation so undefined values are omitted, matching interpreter behavior.
Changes:
- Skip
UndefinedinSetAddand both set-comprehension execution modes. - Preserve invalid-target errors and defined values.
- Add regression coverage for interpreter parity, shared sets, and deduplication.
| File | Description |
|---|---|
| tests/rvm/vm/suites/set_operations.yaml | Tests undefined insertion, shared sets, and invalid targets. |
| tests/rvm/rego/cases/undefined_set_values.yaml | Adds parity cases for both execution modes. |
| src/rvm/vm/dispatch.rs | Prevents SetAdd from inserting undefined values. |
| src/rvm/vm/comprehension.rs | Filters undefined set-comprehension yields in both modes. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Anand Krishnamoorthi (anakrish)
marked this pull request as ready for review
October 16, 2026 03:09
Anand Krishnamoorthi (anakrish)
approved these changes
Oct 16, 2026
David Pokluda (dpokluda)
approved these changes
Oct 16, 2026
Anand Krishnamoorthi (anakrish)
deleted the
copilot/create-smaller-self-contained-prs
branch
October 16, 2026 15:49
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begin splitting the causality/partial-evaluation work into self-contained PRs by isolating an existing RVM correctness bug. Experimental functionality, default-off
explanationsgating, and design benchmarks remain outside this prerequisite PR.UndefinedinSetAddand set-comprehension yields across both VM execution modes. Preserve invalid-target errors and defined values, includingnullandfalse.For missing
input.missing, this rule should produce an empty set—not a set containingUndefined: