Repository navigation
Preserve memory budgets across suspendable execution - #830
Draft
Maksym (maksym-mishchenko) wants to merge 17 commits into
Draft
Maksym (maksym-mishchenko) wants to merge 17 commits into
Maksym (maksym-mishchenko) wants to merge 17 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6592a3a-3255-447c-a539-00a799431708
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
The returned NULL-pointer paths cross explicit nonnull guards, and both logging reports concern numeric test diagnostics, not payloads or absolute addresses. Please review these four CodeQL reports as potential false positives. This assessment covers only the returned paths, capped at five per pointer finding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WI 3522638 requires a per-execution memory budget to remain attached to one suspendable RVM evaluation across execute, HostAwait, resume, sequential thread migration, and terminal cleanup.
This change keeps one allocation-origin account for the execution lifetime, attributes cross-thread frees and reallocations to that account, and preserves typed budget exhaustion through Rust, FFI status 10, and
RegorusMemoryBudgetExceededException. It also covers native resume input parsing and immediate native output/C-string creation while leaving host-await elapsed time, managed host work, sampled profiling, fetch-size limits, and AGS configuration outside this change.The source is conditionally code-accepted at tree pin
531e9ccc6a408954e78bb773bad28bc6a113b8bea02af02cf86c3cdba451e642, based on121e638406c081398336dc3b05874d4f31aecbcf. Existing public C ABI and CLR signatures, status ordinals, dependencies, and no-budget behavior remain unchanged.Dependency-blocked draft — do not merge
Merge requires current-target verification, admitted producer builds and benchmarks, immutable producer identity, performance and platform evidence meeting an approved acceptance contract, and final technical and runtime-safety review. This draft does not authorize package publication, release, AGS adoption, deployment, configuration rollout or WI completion.