Repository navigation
fix: salvage nested strict-mode (#441) and Anthropic transport hardening (#443) onto 0.9.0 - #481
Merged
Seth Juarez (sethjuarez) merged 3 commits intoAug 18, 2026
Conversation
…itter 0.9.0) Salvages the still-valid correctness fix from PR #441, re-authored for main's current state (schema reorg + @typra/emitter 0.9.0): - prompty-openai wire.rs: in OpenAI strict mode, every object property must appear in equired (optional fields are represented as nullable). - Vector structured_output_nested_optional authored at its NEW source of truth schema/model/conformance/vectors/wire.tsp; �ectors.json and the generated python conformance test are regenerated via pm run generate (not hand-edited). PR #441's edit to the legacy spec/vectors/wire/ wire_vectors.json is dropped since main removed that catalog. - spec.md / wire-format.mdx: document the recursive strict-mode rule. Verified: cargo test -p prompty-openai (lib + wire_vectors) 107 passed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Salvages PR #443, re-merged onto main's evolved prompty-anthropic crate: - Add endpoint.rs with shared build_api_url(): adds ANTHROPIC_BASE_URL env fallback and idempotent /v1 handling that main's inline build_url lacked. - executor.rs and models.rs now delegate URL construction to the shared helper; classify transport/SSE failures as the PR intended. - Conflict resolution: kept main's Agent type name (PR predated the Prompty->Agent rename) while adopting the PR's ANTHROPIC_BASE_URL test env guards. Verified: cargo test -p prompty-anthropic — 55 lib + wire/discovery/vectors tests pass; live integration tests remain env-gated (ignored). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 18, 2026
The #441 salvage added the structured_output_nested_optional vector to wire.tsp and regenerated vectors.json + the Python conformance test, but the generated TypeScript vector-conformance.test.ts was inadvertently reverted along with unrelated prettier formatting churn. Regenerated with the TS workspace installed (prettier present) so only the genuine vector addition remains. Fixes the 'regeneration produces no diff' CI gate. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Seth Juarez (sethjuarez)
deleted the
sejuare-microsoft/potential-waddle
branch
August 19, 2026 03:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Salvages the two genuinely-still-missing fixes from the 11 conflicting in-flight PRs (#433, #436-#444, #447), re-authored against current main (emitter 0.9.0 + reorganized schema layout) and verified.
The other 9 PRs are effectively stale: they share a pre-reorg merge-base (~36 commits behind) and predate the @typra/emitter 0.4.x -> 0.9.0 jump and the schema/model/ reorg (contracts/, conformance/, operations/, wire/) with generated-model relocation across 7 runtimes. Rather than fabricate an unbuildable ~90k-line merge, this branch carries only the two fixes whose value is not already present on main.
Commits
Recommendation for remaining PRs
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com