Align df.metrics() instance status counts with persisted df.instances (exclude rollback orphans)#217
Draft
Copilot wants to merge 2 commits into
Draft
Align df.metrics() instance status counts with persisted df.instances (exclude rollback orphans)#217Copilot wants to merge 2 commits into
df.metrics() instance status counts with persisted df.instances (exclude rollback orphans)#217Copilot wants to merge 2 commits into
Conversation
Co-authored-by: pinodeca <32303022+pinodeca@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix rolled-back df.start() leaves failed duroxide.executions rows
Align Jun 9, 2026
df.metrics() instance status counts with persisted df.instances (exclude rollback orphans)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
df.metrics()could report higherfailed_instancesthandf.instances/df.list_instances('failed')after rolled-backdf.start()calls, because failures from orphanduroxide.executionsrows were being counted as workflow failures. This changes metrics semantics to reflect persisted workflow instances for status counts.Metrics source of truth
total_instances,running_instances,completed_instances,failed_instancesnow come fromdf.instances(persisted workflows).total_executionsandtotal_eventscontinue to come fromduroxide.executions/duroxide.history.Query shape
Client::get_system_metrics()usage indf.metrics()with explicit SQL aggregation.df.instanceswithFILTER (...)counts and cross-joins execution/event totals.Regression coverage
tests/e2e/sql/05_monitoring_and_explain.sql:df.start(),df.metrics()instance counters matchdf.instancescounters.