Remove ungated update_groups_cache() call in upgrade script - #3394
Open
Lai Wei (weilai-irl) wants to merge 1 commit into
Open
Remove ungated update_groups_cache() call in upgrade script#3394Lai Wei (weilai-irl) wants to merge 1 commit into
Lai Wei (weilai-irl) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes an unconditional Microsoft Graph groups-cache warm-up from the local_o365 upgrade path to avoid triggering a potentially slow, tenant-wide Graph sync during plugin upgrades (especially when the relevant sync features are not enabled/configured).
Changes:
- Removes the upgrade-time call to
utils::update_groups_cache()(and its Graph client setup/exception handling). - Drops the now-unused
local_o365\feature\cohortsync\mainimport. - Adds an explanatory inline comment documenting why the cache is not warmed during upgrade.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.