Update icon settings in auth_oidc - #3382
Open
Lai Wei (weilai-irl) wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the auth_oidc plugin’s login icon configuration by reducing the available stock icon choices to OIDC-relevant options, adding new SVG assets, and introducing an upgrade-time migration to preserve existing sites’ selected icons when previously-available core Moodle icons are removed.
Changes:
- Replace the stock icon selector list with a curated set (Microsoft/M365/OpenID/Keycloak) and update the default icon choice.
- Add new SVG icon assets and update language strings for the new icon alt texts.
- Add an upgrade step to migrate removed icon selections into the plugin’s custom icon area so existing sites keep the same visual icon.
Reviewed changes
Copilot reviewed 8 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| auth/oidc/version.php | Bumps the plugin version to trigger the upgrade/migration. |
| auth/oidc/settings.php | Replaces icon choices, updates default icon, and changes custom icon accepted upload types. |
| auth/oidc/pix/openid.svg | Adds OpenID stock icon asset. |
| auth/oidc/pix/office_365.svg | Adds Office 365 stock icon asset. |
| auth/oidc/pix/microsoft.svg | Adds Microsoft stock icon asset. |
| auth/oidc/pix/microsoft_365.svg | Adds Microsoft 365 stock icon asset. |
| auth/oidc/pix/microsoft_365_copilot.svg | Adds Microsoft 365 Copilot stock icon asset. |
| auth/oidc/lib.php | Updates custom icon initialization to remove stale extensions and preserve the uploaded extension. |
| auth/oidc/lang/en/auth_oidc.php | Updates icon alt strings and custom icon help text. |
| auth/oidc/db/upgrade.php | Adds an upgrade step to migrate removed icon selections. |
| auth/oidc/classes/utils.php | Implements the icon migration logic into the custom icon area. |
| auth/oidc/classes/loginflow/authcode.php | Updates default icon key and adjusts the rendered name spacing when an icon is shown. |
| auth/oidc/classes/adminsetting/iconselect.css | Minor CSS tweak for icon selection styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lai Wei (weilai-irl)
force-pushed
the
wip-135748-m502
branch
from
August 7, 2026 19:23
da6288c to
1567b4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.