Skip to content

Update icon settings in auth_oidc - #3380

Open
Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_500_STABLEfrom
wip-135748-m500
Open

Update icon settings in auth_oidc#3380
Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_500_STABLEfrom
wip-135748-m500

Conversation

@weilai-irl

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI lite review requested due to automatic review settings August 7, 2026 17:18
@weilai-irl Lai Wei (weilai-irl) self-assigned this Aug 7, 2026
@weilai-irl Lai Wei (weilai-irl) added this to the 2026-03 milestone Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the auth_oidc plugin’s login-page icon configuration by trimming the available stock icon list to OIDC-relevant choices, adding new SVG icons, updating defaults, and introducing an upgrade migration to preserve previously-selected (now-removed) stock icons.

Changes:

  • Replace the stock icon selector options with Microsoft/OIDC-related icons and update the default icon.
  • Add new SVG icon assets and adjust icon-related UI/help text.
  • Add an upgrade migration to move removed stock icon selections into the custom icon file area.

Reviewed changes

Copilot reviewed 8 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
auth/oidc/version.php Bumps plugin version (currently to a float value).
auth/oidc/settings.php Updates icon selector options/default; expands accepted custom icon types.
auth/oidc/pix/openid.svg Adds new OpenID icon asset.
auth/oidc/pix/office_365.svg Adds new Office 365 icon asset.
auth/oidc/pix/microsoft.svg Adds new Microsoft icon asset.
auth/oidc/pix/microsoft_365.svg Adds new Microsoft 365 icon asset.
auth/oidc/pix/microsoft_365_copilot.svg Adds new Microsoft 365 Copilot icon asset.
auth/oidc/lib.php Updates custom icon initialization to remove stale previous extensions and preserve the uploaded extension.
auth/oidc/lang/en/auth_oidc.php Updates icon alt strings and custom icon help text.
auth/oidc/db/upgrade.php Adds upgrade step to migrate removed icon choices.
auth/oidc/classes/utils.php Implements migration logic for removed icon choices into custom icon storage.
auth/oidc/classes/loginflow/authcode.php Updates default icon handling and adjusts display name formatting when showing an icon.
auth/oidc/classes/adminsetting/iconselect.css Tweaks icon selector image spacing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread auth/oidc/version.php
Comment thread auth/oidc/db/upgrade.php
Comment thread auth/oidc/settings.php Outdated
Comment thread auth/oidc/lang/en/auth_oidc.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants