Update icon settings in auth_oidc - #3380
Open
Lai Wei (weilai-irl) wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the auth_oidc plugin’s login-page icon configuration by trimming the available stock icon list to OIDC-relevant choices, adding new SVG icons, updating defaults, and introducing an upgrade migration to preserve previously-selected (now-removed) stock icons.
Changes:
- Replace the stock icon selector options with Microsoft/OIDC-related icons and update the default icon.
- Add new SVG icon assets and adjust icon-related UI/help text.
- Add an upgrade migration to move removed stock icon selections into the custom icon file area.
Reviewed changes
Copilot reviewed 8 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| auth/oidc/version.php | Bumps plugin version (currently to a float value). |
| auth/oidc/settings.php | Updates icon selector options/default; expands accepted custom icon types. |
| auth/oidc/pix/openid.svg | Adds new OpenID icon asset. |
| auth/oidc/pix/office_365.svg | Adds new Office 365 icon asset. |
| auth/oidc/pix/microsoft.svg | Adds new Microsoft icon asset. |
| auth/oidc/pix/microsoft_365.svg | Adds new Microsoft 365 icon asset. |
| auth/oidc/pix/microsoft_365_copilot.svg | Adds new Microsoft 365 Copilot icon asset. |
| auth/oidc/lib.php | Updates custom icon initialization to remove stale previous extensions and preserve the uploaded extension. |
| auth/oidc/lang/en/auth_oidc.php | Updates icon alt strings and custom icon help text. |
| auth/oidc/db/upgrade.php | Adds upgrade step to migrate removed icon choices. |
| auth/oidc/classes/utils.php | Implements migration logic for removed icon choices into custom icon storage. |
| auth/oidc/classes/loginflow/authcode.php | Updates default icon handling and adjusts display name formatting when showing an icon. |
| auth/oidc/classes/adminsetting/iconselect.css | Tweaks icon selector image spacing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lai Wei (weilai-irl)
force-pushed
the
wip-135748-m500
branch
from
August 7, 2026 19:22
b45d019 to
01182e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.