Update icon settings in auth_oidc - #3379
Open
Lai Wei (weilai-irl) wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the auth_oidc plugin’s icon configuration and assets so admins can choose from a smaller set of OIDC-relevant icons, with an upgrade path to preserve previously selected (now-removed) core Moodle icon choices.
Changes:
- Replaced the icon selector options with new OIDC-related icons and updated the default icon.
- Added new icon assets and a migration routine to preserve removed icon selections by copying them into the custom icon area.
- Updated custom icon handling to avoid stale-extension precedence by deleting old
customicon.*files before copying the new upload.
Reviewed changes
Copilot reviewed 8 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| auth/oidc/version.php | Bumps plugin version (currently as a decimal). |
| auth/oidc/settings.php | Updates icon selector options/default; updates custom icon accepted types. |
| auth/oidc/pix/openid.svg | Adds OpenID icon asset. |
| auth/oidc/pix/office_365.svg | Adds Office 365 icon asset. |
| auth/oidc/pix/microsoft.svg | Adds Microsoft icon asset. |
| auth/oidc/pix/microsoft_365.svg | Adds Microsoft 365 icon asset. |
| auth/oidc/pix/microsoft_365_copilot.svg | Adds Microsoft 365 Copilot icon asset. |
| auth/oidc/lib.php | Updates custom icon cache file handling (extension-aware, removes stale files). |
| auth/oidc/lang/en/auth_oidc.php | Updates/introduces icon alt strings and custom icon description. |
| auth/oidc/db/upgrade.php | Adds upgrade step to migrate removed icon choices. |
| auth/oidc/classes/utils.php | Implements migration helper for removed icon choices. |
| auth/oidc/classes/loginflow/authcode.php | Updates default icon and tweaks IDP display name spacing when icon is shown. |
| auth/oidc/classes/adminsetting/iconselect.css | Adjusts icon selector image styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lai Wei (weilai-irl)
force-pushed
the
wip-135748-m405
branch
from
August 7, 2026 19:22
18d62f4 to
84a478f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.