Skip to content

Update icon settings in auth_oidc - #3379

Open
Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_405_STABLEfrom
wip-135748-m405
Open

Update icon settings in auth_oidc#3379
Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_405_STABLEfrom
wip-135748-m405

Conversation

@weilai-irl

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI lite review requested due to automatic review settings August 7, 2026 17:18
@weilai-irl Lai Wei (weilai-irl) self-assigned this Aug 7, 2026
@weilai-irl Lai Wei (weilai-irl) added this to the 2026-03 milestone Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the auth_oidc plugin’s icon configuration and assets so admins can choose from a smaller set of OIDC-relevant icons, with an upgrade path to preserve previously selected (now-removed) core Moodle icon choices.

Changes:

  • Replaced the icon selector options with new OIDC-related icons and updated the default icon.
  • Added new icon assets and a migration routine to preserve removed icon selections by copying them into the custom icon area.
  • Updated custom icon handling to avoid stale-extension precedence by deleting old customicon.* files before copying the new upload.

Reviewed changes

Copilot reviewed 8 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
auth/oidc/version.php Bumps plugin version (currently as a decimal).
auth/oidc/settings.php Updates icon selector options/default; updates custom icon accepted types.
auth/oidc/pix/openid.svg Adds OpenID icon asset.
auth/oidc/pix/office_365.svg Adds Office 365 icon asset.
auth/oidc/pix/microsoft.svg Adds Microsoft icon asset.
auth/oidc/pix/microsoft_365.svg Adds Microsoft 365 icon asset.
auth/oidc/pix/microsoft_365_copilot.svg Adds Microsoft 365 Copilot icon asset.
auth/oidc/lib.php Updates custom icon cache file handling (extension-aware, removes stale files).
auth/oidc/lang/en/auth_oidc.php Updates/introduces icon alt strings and custom icon description.
auth/oidc/db/upgrade.php Adds upgrade step to migrate removed icon choices.
auth/oidc/classes/utils.php Implements migration helper for removed icon choices.
auth/oidc/classes/loginflow/authcode.php Updates default icon and tweaks IDP display name spacing when icon is shown.
auth/oidc/classes/adminsetting/iconselect.css Adjusts icon selector image styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread auth/oidc/version.php
Comment thread auth/oidc/settings.php Outdated
Comment thread auth/oidc/db/upgrade.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants