Fix missing sesskey validation on state-changing admin endpoints - #3378
Open
Patryk Mroczko (patmr7) wants to merge 1 commit into
Open
Fix missing sesskey validation on state-changing admin endpoints#3378Patryk Mroczko (patmr7) wants to merge 1 commit into
Patryk Mroczko (patmr7) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens CSRF protection for Microsoft 365 admin tools in the local_o365 plugin by ensuring state-changing actions validate Moodle’s session key (sesskey).
Changes:
- Added
require_sesskey()to state-changing endpoints (delete actions, queue clear, Teams connection actions, maintenance tools, user connection actions). - Updated generated action URLs to include
sesskeyso the new validation passes for link- and JS-triggered requests. - Replaced some
confirm_sesskey()calls withrequire_sesskey()for consistent enforcement.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
local/o365/cohortsync.php |
Adds require_sesskey() before performing mapping deletion. |
local/o365/classes/page/acp.php |
Enforces sesskey validation on multiple admin actions and updates related URLs to include sesskey. |
local/o365/classes/form/cohortsync.php |
Adds sesskey to the “delete mapping” action URL so deletion continues to work with validation enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.