Fix missing sesskey validation on state-changing admin endpoints - #3377
Open
Patryk Mroczko (patmr7) wants to merge 1 commit into
Open
Fix missing sesskey validation on state-changing admin endpoints#3377Patryk Mroczko (patmr7) wants to merge 1 commit into
Patryk Mroczko (patmr7) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the local_o365 admin UI by enforcing Moodle sesskey validation on state-changing endpoints to mitigate CSRF risks on admin actions.
Changes:
- Added
require_sesskey()to the cohort sync “delete mapping” action. - Added
require_sesskey()to multiple ACP (Admin Control Panel) modes that perform mutations (queue clearing, maintenance actions, team connection actions, and user connection actions). - Updated generated admin/action URLs to include
sesskeywhere needed (including adjusting URL output for the JS-driven POST in usermatch).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| local/o365/cohortsync.php | Requires sesskey for the delete action to prevent CSRF on cohort mapping deletion. |
| local/o365/classes/page/acp.php | Enforces sesskey on multiple state-changing ACP modes and ensures corresponding action URLs include sesskey. |
| local/o365/classes/form/cohortsync.php | Adds sesskey to the “delete mapping” URL so the new validation passes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.