Fix missing sesskey validation on state-changing admin endpoints - #3376
Open
Patryk Mroczko (patmr7) wants to merge 1 commit into
Open
Fix missing sesskey validation on state-changing admin endpoints#3376Patryk Mroczko (patmr7) wants to merge 1 commit into
Patryk Mroczko (patmr7) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the local Microsoft 365 integration admin tools by enforcing Moodle sesskey (CSRF) validation on multiple state-changing endpoints, and by ensuring UI-triggered requests include the sesskey where needed.
Changes:
- Added
require_sesskey()checks to state-changing handlers (e.g., cohort sync deletion, user match queue clearing, maintenance actions, Teams connection actions, user connection actions). - Updated action URLs to include
sesskey => sesskey()so newly-enforced sesskey checks pass when actions are triggered from the UI. - Adjusted URL string output for the user match queue clear AJAX calls to avoid HTML-escaped query separators breaking the POST target.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| local/o365/cohortsync.php | Enforces sesskey validation before deleting cohort sync mappings. |
| local/o365/classes/page/acp.php | Adds/enforces sesskey validation across multiple admin modes and updates relevant action URLs. |
| local/o365/classes/form/cohortsync.php | Adds sesskey to the “delete mapping” action link to satisfy the new validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.