fix: cilium push.sh skip missing images instead of aborting#189
Open
hippogr wants to merge 1 commit into
Open
Conversation
When a local image doesn't exist (e.g. cilium-operator not built), the script now skips it and continues pushing remaining images instead of exiting due to set -e. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Cilium image push helper script so missing local images don’t abort the entire push process under set -euo pipefail, allowing remaining images to be tagged and pushed.
Changes:
- Skip tagging/pushing for images that are not present locally (via
docker image inspect). - Continue pushing other images even if a particular
docker pushfails, then exit non-zero at the end if any pushes failed. - Simplify the final completion message.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+121
to
122
| FAILED=0 | ||
| for local_img in "${!IMAGE_MAP[@]}"; do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a local image doesn't exist (e.g. cilium-operator not built), the script now skips it and continues pushing remaining images instead of exiting due to set -e.