Add ability to build DLL/shared object#21
Conversation
| exit 1 | ||
| fi | ||
| ;; | ||
| o) |
There was a problem hiding this comment.
Sadly -s was already taken and getopts doesn't allow multi character options such as -so :(
There was a problem hiding this comment.
you could go for case sensitive S if you're feeling Spicy
There was a problem hiding this comment.
I'm not feeling that spicy
| /* | ||
| * | ||
| */ |
There was a problem hiding this comment.
Note to self to fill these in
| exit 1 | ||
| fi | ||
| ;; | ||
| o) |
There was a problem hiding this comment.
you could go for case sensitive S if you're feeling Spicy
| #elif INFLATELIB_HAS_VISIBILITY_ATTR | ||
| #define INFLATELIB_EXPORT __attribute__((visibility("default"))) | ||
| #else | ||
| #define INFLATELIB_EXPORT /* Not Windows and no visibility attribute... dont' decorate function declarations */ |
There was a problem hiding this comment.
NIT: dontn't
| #define INFLATELIB_EXPORT /* Not Windows and no visibility attribute... dont' decorate function declarations */ | |
| #define INFLATELIB_EXPORT /* Not Windows and no visibility attribute... don't decorate function declarations */ |
|
|
||
| /* | ||
| * INFLATELIB_BUILD_SHARED The library is being built as a shared library | ||
| * INFLATELIB_CONSUME_SHARED The library is being consumed as a shared library |
There was a problem hiding this comment.
interesting debate about whether shared should be the default mode of consumption or not
There was a problem hiding this comment.
Yeah. Nice thing about being "v0" is that we can delay that decision for now. We can also choose a separate default for the vcpkg port. One thing worth mentioning is that zlib ships as a shared object by default, at least on vcpkg
2 participants
Fixes #20
cc @githuser8372