MCP: trust-by-default file access via --disable-file-reference#40
Closed
Chenglong-MS wants to merge 3 commits into
Closed
MCP: trust-by-default file access via --disable-file-reference#40Chenglong-MS wants to merge 3 commits into
Chenglong-MS wants to merge 3 commits into
Conversation
Contributor
Author
|
Superseded by #41, which is the same changes opened from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the directory-whitelist file-access model in
flint-chart-mcpwith a simpler trust-by-default model plus a single boolean opt-out.File access
data.url(.json/.csv/.tsv) are readable. Relative paths resolve against the working directory; remote URLs remain blocked (SSRF protection).--disable-file-reference(envFLINT_MCP_DISABLE_FILE_REFERENCE): rejects all local file references; agents must pass rows inline viadata.values.--data-roots,--data-root, andFLINT_MCP_DATA_ROOTS. They emit a warning and no longer take effect. The warning steers migrators to simply remove the old flag (not to--disable-file-reference, which is the opposite intent) so existing whitelist users do not accidentally disable file charting.Docs / site / skills
docs/overview.md,docs/tutorials/setup-flint-mcp.md, and the site MCP page to reflect trust-by-default and the new flag.Also included
aggregatenow collapses rows itself (average/meansynonyms), with related flint-js +docs/api-reference.mdupdates.Testing
npm run build— success