chore: upgrade microsoft/fabric provider to 1.10.0#640
Conversation
| display_name = var.workspace_display_name | ||
| description = var.workspace_description | ||
| capacity_id = var.capacity_id | ||
| skip_capacity_state_validation = true |
There was a problem hiding this comment.
skip_capacity_state_validation = true is hardcoded here without an input variable, which means every deployment (including production) skips Fabric capacity state validation. The codebase convention for internal modules requires all variables to be required with no defaults.
Consider adding a required variable to the module:
variable "skip_capacity_state_validation" {
type = bool
description = "When true, skips validation of Fabric capacity state during workspace provisioning. Useful for non-production environments where capacity may be paused."
}Then thread it through src/000-cloud/031-fabric/terraform/main.tf when calling module.fabric_workspace, and set it to true in the CI deployment config (src/000-cloud/031-fabric/ci/terraform/). This lets production callers opt out of skipping validation, giving them a faster failure signal when deploying against a paused or misconfigured capacity.
katriendg
left a comment
katriendg
left a comment
There was a problem hiding this comment.
Thank you for taking on this one, it's pretty complete just missing a few elements to function and pass build.
Add the variable default setting - see inline comment.
Rebase onto latest main. main has moved since this branch was cut — notably #627 added generated ci/terraform/README.md files (including for this component), so rebasing first avoids a docs conflict.
Regenerate Terraform docs after the rebase by running npm run tf-docs. The new variable isn't reflected in the component or CI README.md yet, and generated docs must not be hand-edited. Also the docs will regenerate because of provider version update.
Once those three are in and terraform validate passes on both blueprints, this should be good to go. Thanks again for helping keep the Fabric provider current!
| default = "Microsoft Fabric workspace for the Edge AI Accelerator solution" | ||
| } | ||
|
|
||
| variable "skip_capacity_state_validation" { |
There was a problem hiding this comment.
At the component root level this variable needs a default. Per the repo guideline, a component's public interface variables are optional with a sensible default, while internal module variables (e.g. modules/workspace/variables.tf) stay required with no default — that part is already correct here.
As written (no default), skip_capacity_state_validation becomes a required argument, which breaks every consumer that doesn't pass it. I validated locally and both fabric and fabric-rti blueprints fail terraform validate with Missing required argument. Your ci/terraform/variables.tf variant already sets default = true, so this looks like an accidental omission.
Suggested
variable "skip_capacity_state_validation" {
type = bool
description = "When true, skips validation of Fabric capacity state during workspace provisioning. Useful for non-production environments where capacity may be paused."
default = true
}
PratikWayase
force-pushed
the
chore/upgrade-microsoft-fabric-provider-494
branch
from
288a5a5 to
b61ed04
Compare
📚 Documentation Health ReportGenerated on: 2026-07-06 23:29:20 UTC 📈 Documentation Statistics
🏗️ Three-Tree Architecture Status
🔍 Quality Metrics
This report is automatically generated by the Documentation Automation workflow. |
rezatnoMsirhC
left a comment
rezatnoMsirhC
left a comment
There was a problem hiding this comment.
Looks good to me aside from the failing workflows. Thank you!
📚 Documentation Health ReportGenerated on: 2026-07-09 14:29:35 UTC 📈 Documentation Statistics
🏗️ Three-Tree Architecture Status
🔍 Quality Metrics
This report is automatically generated by the Documentation Automation workflow. |
katriendg
left a comment
katriendg
left a comment
There was a problem hiding this comment.
Thank you @PratikWayase your changes all look good, there is just an issue with the docs, it seems your generated docs were not entirely successful, as the format-tables action did not apply so it's failing linting.
Could you please rerun npm run tf-docs and ensure you see the terminal call on format tables as well (could be there is a missing library if you did not use dev container). Tables should be correctly aligned. It's a minor update.
tapheret2
left a comment
tapheret2
left a comment
There was a problem hiding this comment.
Review pass
Static review of the open diff:
- Looks focused enough for a community review pass
- Please ensure tests/docs match any behavior change
- Call out breaking changes in the PR body if any
Thanks — re-submitted after rate-limit cooldown.
4 participants
Description
Upgrades the
microsoft/fabricTerraform provider from 1.3.0 to 1.10.0 across all Fabric-related Terraform components and blueprints. This PR also enablesskip_capacity_state_validation = truefor the Fabric workspace resource to avoid validation failures when non-production Fabric capacities are paused or suspended.Related Issue
Fixes #494
Type of Change
Implementation Details
1.10.0.>= 1.3.0constraint with a pinned1.10.0version.skip_capacity_state_validation = trueto the Fabric workspace resource as recommended in the issue description.Testing Performed
terraform validate/npm run tf-validate) could not be executed locally because an Azure subscription is required. CI will perform validation.Validation Steps
1.10.0.npm run tf-validate.npm run tflint-fix-all.Checklist
terraform fmton all Terraform codeterraform validateon all Terraform codeaz bicep formaton all Bicep codeaz bicep buildto validate all Bicep codeSecurity Review