Initial attempt to fix carryover events issue on continue-as-new#496
Merged
Conversation
sophiatev
marked this pull request as ready for review
November 11, 2025 01:28
cgillum
commented
Nov 11, 2025
Member
Author
|
@sophiatev your changes look good to me. We'll need another person to sign off on this since I'm the original creator of this PR. |
nytian
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an in-progress attempt to fix #387. These changes are really old and have been stashed away on my dev box for many months. I've merged it with the latest from main and fixed the merge conflicts to the best of my ability.
The bug can be reproduced using the
ContinueAsNewEventsArePreservedtest in test/Grpc.IntegrationTests/OrchestrationPatterns.cs.As far as I remember, I haven't been able to get the test to pass. I'm creating this draft PR as a reference for someone who can hopefully carry this work to the finish line.