Add API for In-process Testing and Add Class-Syntax Integration Tests#476
Conversation
|
Is the goal of this feature to ship it as a public package for other developers to use? If so, we should put this in its own project and make it into a nuget package. But let me know if that was the intention here, or if it's something different. |
| /// </summary> | ||
| public class ClassSyntaxIntegrationTests : IntegrationTestBase | ||
| { | ||
| public ClassSyntaxIntegrationTests(ITestOutputHelper output, GrpcSidecarFixture sidecarFixture) |
There was a problem hiding this comment.
Is the GrpcSidecarFixture using the new test host internally?
There was a problem hiding this comment.
I don't think so, DurableTaskTestHost is like the combination of GrpcSidecarFixture and IntegrationTestBase,. So they two do have some overlap
halspang
left a comment
halspang
left a comment
There was a problem hiding this comment.
Overall this seems good to me, just a few comments.
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net6.0</TargetFramework> |
There was a problem hiding this comment.
I know some of our packages support netstandard2.0 and net6. Do we need to do that here as well or are we OK with just net6?
There was a problem hiding this comment.
Just tried, we are using Grpc.AspNetCore.Server in this test pkg which doesn't support netstandard2.0. I guess we are fine? If there are special customer asking for that then I can move back to add the TFM. Now it's just preview pkg
3 participants
This PR Introduce a new api and package
DurableTaskTestHostfor customer to test their orchestrations in-process