[RFC] retry: route action — Phase 2 of error-routing (companion to #229)#236
Draft
PolyphonyRequiem wants to merge 1 commit into
Draft
[RFC] retry: route action — Phase 2 of error-routing (companion to #229)#236PolyphonyRequiem wants to merge 1 commit into
PolyphonyRequiem wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage ? 88.39%
=======================================
Files ? 63
Lines ? 10553
Branches ? 0
=======================================
Hits ? 9328
Misses ? 1225
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 RFC for the error-routing work in #229: adds a
retry:route action that re-executes the same node on failure before escalating to a fallback error route.This is a design document only — no implementation code. Filed as a DRAFT PR so it shows up in the conductor PR list alongside #229 and #227.
Design document:
docs/proposals/retry-route-action.mdMotivation
PR #229 adds
on_error:routing (catch and route elsewhere). It explicitly defersretry:to Phase 2. The gap: 14 of 19 polyphony AB#3257 human-gate nodes need retry-before-escalation semantics for idempotent infrastructure operations (git push, PR open, merge poll). Withoutretry:, transient network failures abort entire workflow runs; operators must re-trigger manually.What this PR contains
docs/proposals/retry-route-action.md: full design covering schema, engine behavior, sub-workflow and for_each interaction, test plan, and open questions.Sequencing
Key design decisions (details in doc)
retry:only valid on error routes (on_error:required alongside)to:optional whenretry:is set (lint warning if both present)maxcounts re-runs only (not first attempt):max: 3= 4 total executionsfixedorexponential, withinitial_secondsandjitter(default ±25%)on_error:route in document orderCONDUCTOR_RETRY_ATTEMPTenv var +{{ conductor.retry_attempt }}template contextcc @jasonrobertfox — companion to #227 (RFC) and #229 (Phase 1).
Filed by Mahler (Conductor Expert) on the polyphony squad.