Skip to content

Fix HTML injection in code block titles #18866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamesNK wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

Fix HTML injection in code block titles #18866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Aspire.Dashboard/Model/Markdown/HighlightedCodeBlockRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ protected override void Write(HtmlRenderer renderer, CodeBlock obj)
renderer.Writer.Write(@"<div class=""code-block"">");

renderer.Writer.Write(@"<div class=""code-title"">");
renderer.Writer.Write(title);
renderer.WriteEscape(title);
renderer.Writer.Write("</div>");

renderer.Writer.Write(@"<div class=""code-buttons-anchor"">");
Expand Down
21 changes: 21 additions & 0 deletions tests/Aspire.Dashboard.Tests/Markdown/MarkdownProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,27 @@ public void ToHtml_FencedCodeBlock_CopyButtonHasLocalizedAccessibleName()
Assert.Equal("aria-label=\"Localized:GridValueCopyToClipboard\"", copyButton.Groups["accessibleName"].Value);
}

[Fact]
public void ToHtml_FencedCodeBlockLanguageWithHtml_HtmlEncoded()
{
// Arrange
var processor = CreateMarkdownProcessor();

var markdown =
"""
```</div><svg/onload=alert(1)>
In code block.
```
""";

// Act
var html = processor.ToHtml(markdown, inCompleteDocument: true);

// Assert
var title = Regex.Match(html, "<div class=\"code-title\">(.*?)</div>").Groups[1].Value;
Assert.Equal("&lt;/div&gt;&lt;svg/onload=alert(1)&gt;", title);
}

[Fact]
public void ToHtml_ContainsHtml_HtmlIgnored()
{
Expand Down
Loading