-
Notifications
You must be signed in to change notification settings - Fork 342
Update samples for Aspire 13.3 APIs #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IEvangelist
wants to merge
1
commit into
main
Choose a base branch
from
ievangelist/dapine-aspire-api-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
samples/custom-resources/CustomResources.AppHost/AppHost.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,31 @@ | ||
| using CustomResources.AppHost; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| var builder = DistributedApplication.CreateBuilder(args); | ||
|
|
||
| builder.AddTalkingClock("talking-clock"); | ||
|
|
||
| builder.AddTestResource("test"); | ||
|
|
||
| builder.OnBeforeStart(static (@event, cancellationToken) => | ||
| { | ||
| var logger = @event.Services.GetRequiredService<ILoggerFactory>() | ||
| .CreateLogger("CustomResources.AppHost"); | ||
|
|
||
| logger.LogInformation("Starting custom resources sample with {ResourceCount} resources.", @event.Model.Resources.Count); | ||
|
|
||
| return Task.CompletedTask; | ||
| }); | ||
|
|
||
| builder.Eventing.Subscribe<AfterResourcesCreatedEvent>(static (@event, cancellationToken) => | ||
| { | ||
| var logger = @event.Services.GetRequiredService<ILoggerFactory>() | ||
| .CreateLogger("CustomResources.AppHost"); | ||
|
|
||
| logger.LogInformation("Custom resources sample created {ResourceCount} resources.", @event.Model.Resources.Count); | ||
|
|
||
| return Task.CompletedTask; | ||
| }); | ||
|
|
||
| builder.Build().Run(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,8 @@ flowchart LR | |
| **Publish Mode:** | ||
| ```mermaid | ||
| flowchart LR | ||
| Browser --> API[C# API serving<br/>Vite build output<br/>'npm run build'] | ||
| Browser --> Frontend[Static website serving<br/>Vite build output<br/>'npm run build'] | ||
| Frontend -->|Proxy /api| API[C# API] | ||
| API --> Blobs[Azure Blob Storage] | ||
| API --> Queue[Azure Storage Queue] | ||
| API --> SQL[Azure SQL] | ||
|
|
@@ -54,7 +55,7 @@ flowchart LR | |
| - **Dual-Mode Resources**: Azurite/SQL Server containers locally, Azure services in production (`.RunAsEmulator()`, `.RunAsContainer()`) | ||
| - **Free Tier Deployment**: Azure SQL free tier with serverless auto-pause, Container Apps scale-to-zero | ||
| - **Managed Identity**: Password-less authentication to all Azure resources (Storage, SQL, Queues) | ||
| - **Polyglot Stack**: Vite+React frontend embedded in C# API container, SkiaSharp for image processing | ||
| - **Polyglot Stack**: Vite+React frontend published as a static website, SkiaSharp for image processing | ||
| - **OpenTelemetry**: Distributed tracing across upload → queue → worker pipeline | ||
|
|
||
| ## Running Locally | ||
|
|
@@ -194,9 +195,9 @@ else | |
| } | ||
| ``` | ||
|
|
||
| **Container Files Publishing** - Embed Vite build output in API container: | ||
| **Static Website Publishing** - Publish the Vite app as a static website with API proxying: | ||
| ```csharp | ||
| api.PublishWithContainerFiles(frontend, "wwwroot"); | ||
| frontend.PublishAsStaticWebsite("/api", api); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could we make this snippet copy/paste accurate? |
||
| ``` | ||
|
|
||
| ## Performance & Cost Characteristics | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?