continue on error when assigned reviewer is not part of the repo - #708
Open
John Aziz (john0isaac) wants to merge 1 commit into
Open
continue on error when assigned reviewer is not part of the repo#708John Aziz (john0isaac) wants to merge 1 commit into
John Aziz (john0isaac) wants to merge 1 commit into
Conversation
Contributor
|
👋 Thanks for contributing John Aziz (@john0isaac)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s “welcome” GitHub Actions workflows so that the auto-assignment step won’t fail the entire job when the configured assignee cannot be assigned (e.g., they’re not a collaborator on the repo).
Changes:
- Add
continue-on-error: trueto thepozil/auto-assign-issue@v2step in the PR welcome workflow. - Add
continue-on-error: trueto the same step in the issue welcome workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/welcome-pr.yml | Makes the auto-assign step non-blocking for the PR welcome workflow. |
| .github/workflows/welcome-issue.yml | Makes the auto-assign step non-blocking for the issue welcome workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't fail the job when the assigned reviewer is not part of the repo and marks it with warning instead when it fails.
It can work till you change the
assigneesfield to someone who has access to the repo maybe toleestottbut if you don't want that at all I suggest deleting the job from the workflows.Delete from
- name: Auto-assign issueto end of file.