Fix flaky E2E network list test assertion#41009
Open
beena352 wants to merge 1 commit into
Open
Conversation
OneBlue
reviewed
Jul 6, 2026
OneBlue
left a comment
Collaborator
There was a problem hiding this comment.
Do we know where the leak is coming from ? Ideally we should fix the leak so this doesn't potentially cause other failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Remove the exact-count assertion
VERIFY_ARE_EQUAL(2U, networks.size())inWSLCE2E_Network_List_JsonFormatthat intermittently fails when other E2E test classes leak wslc-managed networks into the shared session.PR Checklist
Detailed Description of the Pull Request / Additional comments
The
WSLCE2E_Network_List_JsonFormattest creates two networks and then asserts thatnetwork list --format jsonreturns exactly 2 entries. This is fragile because:ListNetworksreturns all wslc-managed networks in the session, not just this test's.The fix removes only the exact-count check. The test still verifies both expected networks are present by name via
std::find, which is the same pattern the sibling testWSLCE2E_Network_List_QuietOption_OutputsNamesOnlyalready uses correctly.Validation Steps Performed
Verified the test passes locally with the fix applied