-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Wslc events #40971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kvega005
wants to merge
29
commits into
microsoft:master
Choose a base branch
from
kvega005:wslcEvents
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+647
−25
Open
Wslc events #40971
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ba81b75
Add hourly upstream sync workflow for feature/wsl-for-apps
kvega005 50f9ce0
Remove upstream sync workflow
kvega005 c55426c
Merge branch 'microsoft:master' into master
kvega005 0055811
Merge branch 'microsoft:master' into master
kvega005 de88707
Merge branch 'microsoft:master' into master
kvega005 f16fc61
Merge branch 'microsoft:master' into master
kvega005 da31dd2
Merge branch 'microsoft:master' into master
kvega005 b95f237
Merge branch 'microsoft:master' into master
kvega005 2ae93aa
Merge branch 'microsoft:master' into master
kvega005 f805f05
Merge branch 'microsoft:master' into master
kvega005 f2b4090
Merge branch 'microsoft:master' into master
kvega005 07445a2
Merge branch 'microsoft:master' into master
kvega005 9a29435
Merge branch 'microsoft:master' into master
kvega005 ba3bc80
Merge branch 'microsoft:master' into master
kvega005 d11cbbc
Merge branch 'microsoft:master' into master
kvega005 eaae1bc
Merge branch 'microsoft:master' into master
kvega005 9f6a16c
Merge branch 'microsoft:master' into master
kvega005 dcaaccb
Merge branch 'master' of https://github.com/kvega005/WSL
119c17a
Merge branch 'microsoft:master' into master
kvega005 434d93c
Merge branch 'microsoft:master' into master
kvega005 12395f5
WSLC Events
kvega005 2c3e0ff
Fine-tune
kvega005 2f952f8
Fine-tune some more
kvega005 00b370c
Merge branch 'microsoft:master' into master
kvega005 57e22b2
Merge remote-tracking branch 'origin/master' into wslcEvents
kvega005 ba0606b
Address feedback
kvega005 960eba4
Address feedback
kvega005 6ba4dac
Fix syntax
kvega005 b374243
Address feedback
kvega005 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,8 @@ enum class ContainerEvent | |
| Stop, | ||
| Exit, | ||
| Destroy, | ||
| ExecDied | ||
| ExecDied, | ||
| Kill | ||
| }; | ||
|
|
||
| enum class VolumeEvent | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,252 @@ | ||
| // Copyright (C) Microsoft Corporation. All rights reserved. | ||
|
|
||
| #include "precomp.h" | ||
| #include "EventStore.h" | ||
| #include "WSLCSession.h" | ||
| #include "WSLCExecutionContext.h" | ||
| #include <chrono> | ||
| #include "wslc_schema.h" | ||
|
|
||
| using wsl::shared::Localization; | ||
|
|
||
| namespace wsl::windows::service::wslc { | ||
|
|
||
| namespace { | ||
|
|
||
| // Normalizes a seconds-since-epoch window bound from the COM boundary, treating zero as "unset". | ||
| std::optional<uint64_t> ToTimeBound(uint64_t TimeSeconds) | ||
| { | ||
| if (TimeSeconds == 0) | ||
| { | ||
| return std::nullopt; | ||
| } | ||
|
|
||
| return TimeSeconds; | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| void EventStore::Append(wsl::windows::common::wslc_schema::Event Event) | ||
| { | ||
| std::lock_guard lock(m_lock); | ||
|
|
||
| m_events.push_back(std::move(Event)); | ||
|
|
||
| if (m_events.size() > c_eventRingCapacity) | ||
| { | ||
| m_events.pop_front(); | ||
| ++m_firstSequenceNumber; | ||
| } | ||
|
|
||
| m_updated.notify_all(); | ||
| } | ||
|
|
||
| void EventStore::Record(std::string&& Type, std::string&& Action, const std::string& ActorId, std::optional<uint64_t> TimeSeconds) noexcept | ||
| try | ||
| { | ||
| wsl::windows::common::wslc_schema::Event event; | ||
| event.Type = std::move(Type); | ||
| event.Action = std::move(Action); | ||
| event.Actor.ID = ActorId; | ||
|
|
||
| event.time = TimeSeconds.value_or(static_cast<uint64_t>( | ||
| std::chrono::duration_cast<std::chrono::seconds>(std::chrono::system_clock::now().time_since_epoch()).count())); | ||
|
|
||
| Append(std::move(event)); | ||
| } | ||
| CATCH_LOG() | ||
|
|
||
| namespace { | ||
|
|
||
| // Values sharing a key are OR'd, distinct keys are AND'd. Unrecognized keys are ignored. | ||
| bool EventMatchesFilters(const wsl::windows::common::wslc_schema::Event& event, const std::map<std::string, std::vector<std::string>>& filters) | ||
| { | ||
| for (const auto& [key, values] : filters) | ||
| { | ||
| if (key == "type") | ||
| { | ||
| if (!std::ranges::any_of(values, [&](const std::string& v) { return event.Type == v; })) | ||
| { | ||
| return false; | ||
| } | ||
| } | ||
| else if (key == "event") | ||
| { | ||
| if (!std::ranges::any_of(values, [&](const std::string& v) { return event.Action == v; })) | ||
| { | ||
| return false; | ||
| } | ||
| } | ||
| else if (key == "container") | ||
| { | ||
| if (event.Type != "container" || | ||
| !std::ranges::any_of(values, [&](const std::string& v) { return event.Actor.ID == v; })) | ||
| { | ||
| return false; | ||
| } | ||
| } | ||
| else if (key == "image") | ||
| { | ||
| if (event.Type != "image" || !std::ranges::any_of(values, [&](const std::string& v) { return event.Actor.ID == v; })) | ||
| { | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| Microsoft::WRL::ComPtr<IWSLCEventStream> EventStore::CreateStream( | ||
| Microsoft::WRL::ComPtr<WSLCSession> Session, uint64_t SinceTime, uint64_t UntilTime, std::map<std::string, std::vector<std::string>> Filters) | ||
| { | ||
| // A non-zero until earlier than since describes a backwards, empty window. | ||
| THROW_HR_WITH_USER_ERROR_IF( | ||
| E_INVALIDARG, Localization::MessageWslcEventsInvalidTimeWindow(SinceTime, UntilTime), UntilTime != 0 && SinceTime > UntilTime); | ||
|
|
||
| Microsoft::WRL::ComPtr<EventStream> stream; | ||
| THROW_IF_FAILED(Microsoft::WRL::MakeAndInitialize<EventStream>(&stream, std::move(Session), this, SinceTime, UntilTime, std::move(Filters))); | ||
|
|
||
| return stream; | ||
| } | ||
|
|
||
| std::optional<wsl::windows::common::wslc_schema::Event> EventStore::GetLockHeld(uint64_t SequenceNumber) | ||
| { | ||
| // Callers resync a lagging reader before reaching here, so the requested event is never evicted. | ||
| WI_ASSERT(SequenceNumber >= m_firstSequenceNumber); | ||
|
|
||
| const uint64_t index = SequenceNumber - m_firstSequenceNumber; | ||
| if (index >= m_events.size()) | ||
| { | ||
| return std::nullopt; | ||
| } | ||
|
|
||
| return m_events[index]; | ||
| } | ||
|
|
||
| bool EventStore::WaitForEvent(std::unique_lock<std::mutex>& Lock, uint64_t SequenceNumber, std::optional<uint64_t> Until) | ||
| { | ||
| // Ready once the reader's event is buffered, its slot is evicted, or the session terminates. | ||
| // Eviction while parked wakes us too, so the caller reports the gap on its next pass. | ||
| const auto ready = [&] { return m_terminating || SequenceNumber < m_firstSequenceNumber + m_events.size(); }; | ||
|
|
||
| if (Until.has_value()) | ||
| { | ||
| // Until is Unix seconds and system_clock shares that epoch, so it doubles as the wait deadline. | ||
| const std::chrono::sys_seconds deadline{std::chrono::seconds{static_cast<int64_t>(Until.value())}}; | ||
| if (!m_updated.wait_until(Lock, deadline, ready)) | ||
| { | ||
| return false; | ||
| } | ||
| } | ||
| else | ||
| { | ||
| m_updated.wait(Lock, ready); | ||
| } | ||
|
|
||
| THROW_HR_IF(E_ABORT, m_terminating); | ||
| return true; | ||
| } | ||
|
|
||
| std::optional<wsl::windows::common::wslc_schema::Event> EventStore::Get( | ||
| std::optional<uint64_t>& SequenceNumber, | ||
| std::optional<uint64_t> Since, | ||
| std::optional<uint64_t> Until, | ||
| const std::map<std::string, std::vector<std::string>>& Filters) | ||
| { | ||
| std::unique_lock lock(m_lock); | ||
|
|
||
| // Position the reader. A first read (no sequence number yet) starts at the oldest buffered | ||
| // event | ||
| SequenceNumber = SequenceNumber.value_or(m_firstSequenceNumber); | ||
|
|
||
| while (true) | ||
| { | ||
| // A reader that has fallen behind the ring missed events to eviction: reset it so the | ||
| // next call starts fresh at the oldest buffered event, and report the gap. | ||
| if (SequenceNumber.value() < m_firstSequenceNumber) | ||
| { | ||
| SequenceNumber = std::nullopt; | ||
| THROW_HR(WSLC_E_EVENTS_LOST); | ||
| } | ||
|
|
||
| if (!WaitForEvent(lock, SequenceNumber.value(), Until)) | ||
| { | ||
| // The until window elapsed with no further event: the stream is finished. | ||
| return std::nullopt; | ||
| } | ||
|
|
||
| // Evicted while parked: loop back to reset and report the gap. | ||
| // TODO: A burst of more than c_eventRingCapacity events between the wake and reacquiring the | ||
| // lock can evict this reader's event before it is read, forcing a WSLC_E_EVENTS_LOST. Redesign | ||
| // so that every parked reader is guaranteed to observe an event before the next write can evict | ||
| // it. | ||
| if (SequenceNumber.value() < m_firstSequenceNumber) | ||
| { | ||
| continue; | ||
| } | ||
|
|
||
| const auto event = GetLockHeld(SequenceNumber.value()).value(); | ||
|
|
||
| // An event past the until-bound closes the window: the stream is finished. | ||
| if (Until.has_value() && event.time > Until.value()) | ||
| { | ||
| return std::nullopt; | ||
| } | ||
|
|
||
| // Advance past this event so the next read resumes at the following one. | ||
| SequenceNumber.value()++; | ||
|
|
||
| // Return the event if it falls within the since-bound and matches the caller's filters; | ||
| // otherwise loop to skip it. | ||
| if ((!Since.has_value() || event.time >= Since.value()) && EventMatchesFilters(event, Filters)) | ||
| { | ||
| return event; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| void EventStore::OnSessionTerminating() | ||
| { | ||
| { | ||
| std::lock_guard lock(m_lock); | ||
| m_terminating = true; | ||
| } | ||
|
|
||
| m_updated.notify_all(); | ||
| } | ||
|
|
||
| HRESULT EventStream::RuntimeClassInitialize( | ||
| Microsoft::WRL::ComPtr<WSLCSession> Session, | ||
| EventStore* Store, | ||
| uint64_t SinceTime, | ||
| uint64_t UntilTime, | ||
| std::map<std::string, std::vector<std::string>> Filters) | ||
| { | ||
| m_session = std::move(Session); | ||
| m_store = Store; | ||
| m_since = ToTimeBound(SinceTime); | ||
| m_until = ToTimeBound(UntilTime); | ||
| m_filters = std::move(Filters); | ||
| return S_OK; | ||
| } | ||
|
|
||
| HRESULT EventStream::GetNext(LPSTR* EventJson) | ||
| try | ||
| { | ||
| RETURN_HR_IF_NULL(E_POINTER, EventJson); | ||
| *EventJson = nullptr; | ||
|
|
||
| const auto event = m_store->Get(m_nextSequenceNumber, m_since, m_until, m_filters); | ||
| if (!event.has_value()) | ||
| { | ||
| return WSLC_E_EVENT_STREAM_FINISHED; | ||
| } | ||
|
|
||
| *EventJson = wil::make_unique_ansistring<wil::unique_cotaskmem_ansistring>(wsl::shared::ToJson(event.value()).c_str()).release(); | ||
| return S_OK; | ||
| } | ||
| CATCH_RETURN(); | ||
|
|
||
| } // namespace wsl::windows::service::wslc | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary for this change, but ideally we should also wait for the caller's process, otherwise if a user runs
wslc eventsand then ctrl-c, a thread on the service side could get stuck here until an event is emitted to unblock itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly condition_variables don't easily let us wait for multiple events so we might need to make our own for this