-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add configurable storage path for the default wslc session #40956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benhillis
merged 9 commits into
master
from
user/benhill/wslc-default-session-storage-path
Jul 7, 2026
+111
−7
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
90b47c8
Add configurable storage path for the default wslc session
0655215
Clarify storagePath is a base directory in settings template
9a2b4d3
wslc: warn when configured storagePath would orphan existing default-…
17103b9
wslc: address review nits on storagePath setting
c9f8bda
wslc: fix localization comment for storage-orphaned string
40f4d5e
wslc: lock session.storagePath key name in orphaned-storage warning
a6cf949
wslc: simplify storagePath warning to custom-location notice
d8c3eed
wslc: emit storagePath warning from wslcsession at VHD creation
6d67c2c
wslc: fix CI clang-format and storage-flags validation test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,12 +86,20 @@ struct SessionSettings | |
| static std::unique_ptr<SessionSettings> Default(HANDLE UserToken, const std::wstring& ResolvedName) | ||
| { | ||
| auto userSettings = LoadUserSettings(UserToken); | ||
| auto localAppData = wsl::windows::common::filesystem::GetLocalAppDataPath(UserToken); | ||
|
|
||
| auto storagePath = (localAppData / wsl::windows::wslc::DefaultStorageSubPath / ResolvedName).wstring(); | ||
| auto configuredStorageBase = userSettings.Get<settings::Setting::SessionStoragePath>(); | ||
| const bool customConfigured = !configuredStorageBase.empty(); | ||
| const std::filesystem::path defaultBase = wsl::windows::common::filesystem::GetLocalAppDataPath(UserToken); | ||
| const std::filesystem::path storageBase = | ||
| customConfigured ? std::filesystem::path(wsl::shared::string::MultiByteToWide(configuredStorageBase)) : defaultBase; | ||
|
|
||
| const auto storageDir = storageBase / wsl::windows::wslc::DefaultStorageSubPath / ResolvedName; | ||
|
|
||
| // wslcsession emits the custom-location warning when it actually creates the VHD, so the notice | ||
| // fires once at creation without a service-side callback that could stall CreateSession. | ||
| const auto storageFlags = customConfigured ? WSLCSessionStorageFlagsWarnCustomLocation : WSLCSessionStorageFlagsNone; | ||
|
|
||
| return std::unique_ptr<SessionSettings>( | ||
| new SessionSettings(std::wstring(ResolvedName), std::move(storagePath), WSLCSessionStorageFlagsNone, userSettings)); | ||
| return std::unique_ptr<SessionSettings>(new SessionSettings(std::wstring(ResolvedName), storageDir.wstring(), storageFlags, userSettings)); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: We could use |
||
| } | ||
|
|
||
| // Custom session: caller provides name and storage path. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.