Read spidL from SAMLRequest Authentication Extensions (highest priority) - #94
Open
mtagliaferri86 with Copilot wants to merge 2 commits into
Open
Read spidL from SAMLRequest Authentication Extensions (highest priority)#94mtagliaferri86 with Copilot wants to merge 2 commits into
mtagliaferri86 with Copilot wants to merge 2 commits into
Conversation
mtagliaferri86
marked this pull request as ready for review
July 9, 2026 10:39
Copilot
AI
changed the title
[WIP] Add extraction of spidL from SAMLRequest authentication extensions
Read spidL from SAMLRequest Authentication Extensions (highest priority)
Jul 9, 2026
mtagliaferri86
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spidL was only extracted from referer, relay state, or wctx query strings. This adds support for reading it directly from the
Extensionselement in the SAMLRequest, taking precedence over all other sources.Changes
SPIDOptions— New configurableSpidLElementNameproperty (default:"ext:spidL"), paired with the existingExtensionsElementName("samlp:Extensions"). Both are now surfaced inappsettings.json.RequestSAMLAsXMLExtensions— NewGetSpidLFromExtensions()extension method, following the same pattern asGetSpidACSFromExtensions(). Handles both prefixed (ext:spidL) and unprefixed element names.ISPIDService/SPIDService—GetSPIDLValuegains an optionalXmlDocument requestAsXmlparameter. When provided, Extensions are checked first; validity rules (ValidSPIDLlist) apply equally to this path. Falls back to existing referer → relaystate → wctx → default chain on miss or invalid value.FederatorRequestService— PassesrequestAsXmltoGetSPIDLValue.Priority order (updated)
ext:spidLinsidesamlp:Extensionsof the SAMLRequest ← newExample SAMLRequest fragment that will now be honoured: