Changed API endpoint, Fixes #11 - #12
Conversation
|
Hi cagatay odabasi (@cagbal), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
| import java.util.HashMap; | ||
|
|
||
|
|
||
| public class VisionServiceRestClientNew implements VisionServiceClient { |
There was a problem hiding this comment.
I wonder if there wouldn't be better and much clearer if prefix new would be at the beginning = I mean NewVisionServiceRestClient.
Deleted user (ghost)
left a comment
There was a problem hiding this comment.
Well, that's my mistake. In previous MR I added the latest vision dependencies, but I didn't check like you did. Thanks for your pull request.
|
Hi @piotrek1543. My naming was a bit bad! I committed your suggestion. Thanks! |
I could not modify com.microsoft.projectoxford.vision.VisionServiceRestClient file; therefore, created a new class(com.microsoft.mimickeralarm.utilities.VisionServiceRestClientNew) which is the same with this, but the API strings are up-to-date.
I know it's not the best way, but now, the color reasoning seems working.