Skip to content
This repository was archived by the owner on Jul 19, 2024. It is now read-only.

Changed API endpoint, Fixes #11 - #12

Open
cagatay odabasi (cagbal) wants to merge 2 commits into
microsoft:masterfrom
cagbal:master
Open

Changed API endpoint, Fixes #11#12
cagatay odabasi (cagbal) wants to merge 2 commits into
microsoft:masterfrom
cagbal:master

Conversation

@cagbal

Copy link
Copy Markdown

I could not modify com.microsoft.projectoxford.vision.VisionServiceRestClient file; therefore, created a new class(com.microsoft.mimickeralarm.utilities.VisionServiceRestClientNew) which is the same with this, but the API strings are up-to-date.

I know it's not the best way, but now, the color reasoning seems working.

@msftclas

Hi cagatay odabasi (@cagbal), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftgits

Copy link
Copy Markdown
Contributor

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

import java.util.HashMap;


public class VisionServiceRestClientNew implements VisionServiceClient {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there wouldn't be better and much clearer if prefix new would be at the beginning = I mean NewVisionServiceRestClient.

@ghost Deleted user (ghost) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's my mistake. In previous MR I added the latest vision dependencies, but I didn't check like you did. Thanks for your pull request.

@cagbal

Copy link
Copy Markdown
Author

Hi @piotrek1543. My naming was a bit bad! I committed your suggestion. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants