Skip to content

fix: validate AI-generated ontologies against Fabric IQ rules #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mathew Benjamin (mathewtbenjamin) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate AI-generated ontologies against Fabric IQ rules #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/components/NLBuilderModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { useState, useRef, useEffect } from 'react';
import { motion } from 'framer-motion';
import { X, Sparkles, Send, Loader2, Check, AlertCircle, Edit3, Mic, MicOff } from 'lucide-react';
import { useAppStore } from '../store/appStore';
import { validateOntology } from '../store/designerStore';
import type { ValidationError } from '../store/designerStore';
import type { Ontology } from '../data/ontology';

// Web Speech API types
Expand Down Expand Up @@ -53,6 +55,15 @@ interface NLBuilderModalProps {

type Step = 'input' | 'loading' | 'preview' | 'error';

const MAX_DISPLAYED_VALIDATION_ERRORS = 5;

function formatValidationErrors(errors: ValidationError[]): string {
const shown = errors.slice(0, MAX_DISPLAYED_VALIDATION_ERRORS).map((e) => `• ${e.message}`);
const remaining = errors.length - shown.length;
const suffix = remaining > 0 ? `\n…and ${remaining} more` : '';
return `Generated ontology failed validation:\n${shown.join('\n')}${suffix}`;
}

export function NLBuilderModal({ onClose }: NLBuilderModalProps) {
const [description, setDescription] = useState('');
const [step, setStep] = useState<Step>('input');
Expand Down Expand Up @@ -213,6 +224,13 @@ export function NLBuilderModal({ onClose }: NLBuilderModalProps) {
color: entity.color || defaultColors[index % defaultColors.length]
}));

// Run the same Fabric IQ rule set the designer uses (issue #84):
// consistent attribute types, identifier type restrictions, required identifiers.
const validationErrors = validateOntology(ontology);
if (validationErrors.length > 0) {
throw new Error(formatValidationErrors(validationErrors));
}

setGeneratedOntology(ontology);
setEditedJson(JSON.stringify(ontology, null, 2));
setStep('preview');
Expand All @@ -227,6 +245,11 @@ export function NLBuilderModal({ onClose }: NLBuilderModalProps) {

try {
const ontologyToApply = editMode ? JSON.parse(editedJson) : generatedOntology;
const validationErrors = validateOntology(ontologyToApply);
if (validationErrors.length > 0) {
setError(formatValidationErrors(validationErrors));
return;
}
loadOntology(ontologyToApply);
handleClose();
} catch {
Expand Down