Merge remote-tracking branch 'origin/master' into user/eleretzk/rethrow-errors

Author: Eliran Eretz-Kedosha

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@microsoft/objectstoreprovider",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "description": "A cross-browser object store library",
   "author": "DataStack Team eleretzk@microsoft.com",
   "scripts": {

src/IndexedDbProvider.ts

@@ -159,7 +159,7 @@ export class IndexedDbProvider extends DbProvider {
         resolve(req.result);
       };
       req.onerror = (ev) => {
-        reject(ev);
+        reject((ev.target as IDBRequest)?.error ?? ev);
       };
     });
   }
@@ -596,27 +596,19 @@ export class IndexedDbProvider extends DbProvider {
             isCopyRequired: false,
             upgradeSteps,
             ...upgradeMetadata,
-            errorName: err?.target?.error?.name || "Unknown",
+            errorName: err?.target?.error?.name || err?.name || "Unknown",
             errorMessage: err
               ? `${
                   err?.target?.error?.message || err?.message || "Unknown error"
-                } (name: ${err?.target?.error?.name || "Unknown"})`
+                } (name: ${err?.target?.error?.name || err?.name || "Unknown"})`
               : "Unknown error occurred during upgrade",
           });
         }
 
-        if (
-          err &&
-          err.type === "error" &&
-          err.target &&
-          err.target.error &&
-          err.target.error.name === "VersionError"
-        ) {
+        if (err instanceof DOMException && err.name === "VersionError") {
           if (!wipeIfExists) {
             this.logWriter.log(
-              `Database version too new, Wiping: ${
-                err.target.error.message || err.target.error.name
-              }`
+              `Database version too new, Wiping: ${err.message || err.name}`
             );
 
             return this.open(dbName, schema, true, verbose);
@@ -625,7 +617,7 @@ export class IndexedDbProvider extends DbProvider {
         this.logWriter.error(
           `Error opening db, message: ${
             err?.target?.error?.message || err?.message || "Unknown error"
-          }, name: ${err?.target?.error?.name || "Unknown"}`,
+          }, name: ${err?.target?.error?.name || err?.name || "Unknown"}`,
           {
             dbName,
           }
@@ -751,7 +743,7 @@ export class IndexedDbProvider extends DbProvider {
 }
 
 // DbTransaction implementation for the IndexedDB DbProvider.
-class IndexedDbTransaction implements DbTransaction {
+export class IndexedDbTransaction implements DbTransaction {
   private _stores: IDBObjectStore[];
 
   constructor(
@@ -801,10 +793,12 @@ class IndexedDbTransaction implements DbTransaction {
 
         lockHelper.transactionFailed(
           this._transToken,
-          "IndexedDbTransaction OnError: " +
-            errorDetail +
-            ", History: " +
-            history.join(",")
+          new Error(
+            "IndexedDbTransaction OnError: " +
+              errorDetail +
+              ", History: " +
+              history.join(",")
+          )
         );
       };
 
@@ -826,10 +820,12 @@ class IndexedDbTransaction implements DbTransaction {
 
         lockHelper.transactionFailed(
           this._transToken,
-          "IndexedDbTransaction Aborted, Error: " +
-            errorDetail +
-            ", History: " +
-            history.join(",")
+          new Error(
+            "IndexedDbTransaction Aborted, Error: " +
+              errorDetail +
+              ", History: " +
+              history.join(",")
+          )
         );
       };
     }

src/ObjectStoreProvider.ts

@@ -244,7 +244,10 @@ export abstract class DbProvider {
 
   clearAllData(): Promise<void> {
     var storeNames = this._schema!!!.stores.map((store) => store.name);
+    return this.clearStores(storeNames);
+  }
 
+  clearStores(storeNames: string[]): Promise<void> {
     return this.openTransaction(storeNames, true).then((trans) => {
       const clearers = storeNames.map((storeName) => {
         const store = attempt(() => {

src/TransactionLockHelper.ts

@@ -170,7 +170,7 @@ export class TransactionLockHelper {
     this._cleanTransaction(token);
   }
 
-  transactionFailed(token: TransactionToken, message: string) {
+  transactionFailed(token: TransactionToken, message: string | Error) {
     const pendingTransIndex = findIndex(
       this._pendingTransactions,
       (trans) => trans.token === token
@@ -183,7 +183,9 @@ export class TransactionLockHelper {
         const toResolve = pendingTrans.completionDefer;
         this._pendingTransactions.splice(pendingTransIndex, 1);
         pendingTrans.completionDefer = undefined;
-        toResolve.reject(new Error(message));
+        toResolve.reject(
+          message instanceof Error ? message : new Error(message)
+        );
       } else {
         throw new Error(
           "Failing a transaction that has already been completed. Stores: " +