rethrow errors

Author: Eliran Eretz-Kedosha

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@microsoft/objectstoreprovider",
-  "version": "0.8.7",
+  "version": "0.9.0",
   "description": "A cross-browser object store library",
   "author": "DataStack Team eleretzk@microsoft.com",
   "scripts": {

src/InMemoryProvider.ts

@@ -863,7 +863,7 @@ class InMemoryIndex extends DbIndexFTSFromRangeQueries {
       );
     });
     if (isError(keys)) {
-      return Promise.reject(void 0);
+      return Promise.reject(keys);
     }
     return Promise.resolve(keys);
   }

src/IndexedDbProvider.ts

@@ -192,7 +192,7 @@ export class IndexedDbProvider extends DbProvider {
           { dbName }
         );
       }
-      this.logWriter.log(`Wiping db success`, { dbName });
+      this.logWriter.log(`Wiping db completed`, { dbName });
     }
 
     this._lockHelper = new TransactionLockHelper(schema, true);
@@ -208,12 +208,34 @@ export class IndexedDbProvider extends DbProvider {
       upgradeScenarioStartTime: 0,
     };
 
+    dbOpen.onblocked = () => {
+      this.logWriter.error(
+        `Database open is blocked by an existing connection that hasn't closed. ` +
+          `The open request will not proceed until all other connections are closed.`,
+        { dbName }
+      );
+    };
+
     dbOpen.onupgradeneeded = (event) => {
+      const dataLoss = event.dataLoss;
+      const dataLossMessage = event.dataLossMessage;
+
+      if (dataLoss === "total") {
+        this.logWriter.error(
+          `IndexedDB reported total data loss during upgrade: ${
+            dataLossMessage || "(no message)"
+          }`,
+          { dbName }
+        );
+      }
+
       upgradeMetadata = {
         oldVersion: event.oldVersion,
         newVersion: schema.version,
         upgradeScenarioStartTime: Date.now(),
         upgradeStartTimePerformanceMarker: performance.now(),
+        dataLoss: dataLoss,
+        dataLossMessage: dataLossMessage,
       };
 
       const db: IDBDatabase = dbOpen.result;
@@ -490,6 +512,7 @@ export class IndexedDbProvider extends DbProvider {
                   `Error when iterating over cursor on idb index, message: ${err?.message}`,
                   { storeName: storeSchema.name }
                 );
+                throw err;
               }
             )
           );
@@ -528,6 +551,13 @@ export class IndexedDbProvider extends DbProvider {
           }
 
           this._db = db;
+          this._db.onversionchange = () => {
+            this.logWriter.warn(
+              `Database version change requested by another connection. ` +
+                `Keeping this connection open; the requesting connection will be blocked.`,
+              { dbName }
+            );
+          };
           this._db.onclose = (event: Event) => {
             if (this._handleOnClose) {
               // instantiate payload
@@ -568,7 +598,9 @@ export class IndexedDbProvider extends DbProvider {
             ...upgradeMetadata,
             errorName: err?.target?.error?.name || "Unknown",
             errorMessage: err
-              ? `${err?.message} ${err?.target?.error} ${err?.target?.error?.name}`
+              ? `${
+                  err?.target?.error?.message || err?.message || "Unknown error"
+                } (name: ${err?.target?.error?.name || "Unknown"})`
               : "Unknown error occurred during upgrade",
           });
         }
@@ -591,7 +623,9 @@ export class IndexedDbProvider extends DbProvider {
           }
         }
         this.logWriter.error(
-          `Error opening db, message: ${err?.message} ${err?.target?.error} ${err?.target?.error?.name}`,
+          `Error opening db, message: ${
+            err?.target?.error?.message || err?.message || "Unknown error"
+          }, name: ${err?.target?.error?.name || "Unknown"}`,
           {
             dbName,
           }
@@ -632,6 +666,13 @@ export class IndexedDbProvider extends DbProvider {
     }
 
     return new Promise((resolve, reject) => {
+      trans.onblocked = () => {
+        this.logWriter.error(
+          `Database deletion is blocked by an existing connection that hasn't closed. ` +
+            `The delete request will not proceed until all other connections are closed.`,
+          { dbName: this._dbName }
+        );
+      };
       trans.onsuccess = () => {
         resolve(void 0);
       };
@@ -743,14 +784,15 @@ class IndexedDbTransaction implements DbTransaction {
       };
 
       this._trans.onerror = () => {
-        history.push(
-          "error-" + (this._trans.error ? this._trans.error.message : "")
-        );
+        const errorDetail = this._trans.error
+          ? `${this._trans.error.name}: ${this._trans.error.message}`
+          : "Unknown error";
+        history.push("error-" + errorDetail);
 
         if (history.length > 1) {
           this.logWriter.warn(
             "IndexedDbTransaction Errored after Resolution, Swallowing. Error: " +
-              (this._trans.error ? this._trans.error.message : undefined) +
+              errorDetail +
               ", History: " +
               history.join(",")
           );
@@ -760,21 +802,22 @@ class IndexedDbTransaction implements DbTransaction {
         lockHelper.transactionFailed(
           this._transToken,
           "IndexedDbTransaction OnError: " +
-            (this._trans.error ? this._trans.error.message : undefined) +
+            errorDetail +
             ", History: " +
             history.join(",")
         );
       };
 
       this._trans.onabort = () => {
-        history.push(
-          "abort-" + (this._trans.error ? this._trans.error.message : "")
-        );
+        const errorDetail = this._trans.error
+          ? `${this._trans.error.name}: ${this._trans.error.message}`
+          : "Unknown error";
+        history.push("abort-" + errorDetail);
 
         if (history.length > 1) {
           this.logWriter.warn(
             "IndexedDbTransaction Aborted after Resolution, Swallowing. Error: " +
-              (this._trans.error ? this._trans.error.message : undefined) +
+              errorDetail +
               ", History: " +
               history.join(",")
           );
@@ -784,7 +827,7 @@ class IndexedDbTransaction implements DbTransaction {
         lockHelper.transactionFailed(
           this._transToken,
           "IndexedDbTransaction Aborted, Error: " +
-            (this._trans.error ? this._trans.error.message : undefined) +
+            errorDetail +
             ", History: " +
             history.join(",")
         );
@@ -1150,7 +1193,7 @@ class IndexedDbStore implements DbStore {
         highRangeExclusive
       )
       .then((keys) => {
-        this.remove(keys);
+        return this.remove(keys);
       });
   }
 

src/ObjectStoreProvider.ts

@@ -111,6 +111,10 @@ export type UpgradeMetadata = {
   newVersion: number;
   upgradeScenarioStartTime: number;
   upgradeStartTimePerformanceMarker: number;
+  /** Non-standard Chromium extension: "none" or "total". Indicates whether data was lost during upgrade. */
+  dataLoss?: "none" | "total";
+  /** Non-standard Chromium extension: message describing the data loss, if any. */
+  dataLossMessage?: string;
 };
 
 export type UpgradeDetails = UpgradeMetadata & {