Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts feature flag resolution behavior to treat duplicate feature flag ids as “last one wins,” and adds tests to validate the behavior in both sync and async FeatureManager usage.
Changes:
- Update feature flag lookup to prefer the last occurrence when multiple feature flags share the same
id. - De-duplicate
list_feature_flag_names()output so duplicate ids are only listed once. - Add sync and async unit tests covering duplicate-id behavior; add
.envto.gitignore.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
featuremanagement/_featuremanagerbase.py |
Implements last-one-wins lookup and de-duplicates feature flag name listing. |
tests/test_feature_manager.py |
Adds sync test asserting last duplicate wins and names are unique. |
tests/test_feature_manager_async.py |
Adds async test asserting last duplicate wins and names are unique. |
.gitignore |
Ignores .env files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #52
Contribution checklist:
General Guidelines and Best Practices