Repository navigation
[CI] Add --config "$RUST_CONFIG" to baseline runs - #1562
Merged
Merged
Conversation
Alex Razumov (arrayka)
requested review from
a team
and
a balanced review from Copilot
November 2, 2026 21:07
Alex Razumov (arrayka)
enabled auto-merge (squash)
November 2, 2026 21:08
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the changes applying the shared Rust configuration to baseline CI runs.
No open issues 🎉
What changed in this PR
Completes the follow-up to #1516 by applying the shared warnings-as-errors configuration to baseline CI runs now that the required fixes have landed in main.
Changes:
- Adds
--config "$RUST_CONFIG"to the baseline disk benchmark command. - Adds the same configuration to baseline LLVM-line measurement, matching current-code runs.
| File | Description |
|---|---|
.github/workflows/disk-benchmarks.yml |
Applies the shared Rust configuration to baseline benchmarks. |
.github/workflows/ci.yml |
Applies the shared Rust configuration to baseline LLVM-line measurement. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
- Coverage 91.03% 91.00% -0.03%
==========================================
Files 605 607 +2
Lines 125494 125815 +321
==========================================
+ Hits 114238 114494 +256
- Misses 11256 11321 +65
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Aditya Krishnan (arkrishn94)
approved these changes
Nov 2, 2026
Mark Hildebrand (hildebrandmw)
approved these changes
Nov 2, 2026
juchen-ms (partychen)
approved these changes
Nov 3, 2026
Suhas Jayaram Subramanya (suhasjs)
pushed a commit
that referenced
this pull request
Nov 3, 2026
This is a follow-up to #1516. This PR enables `--config "$RUST_CONFIG"` for the baseline versions of llvm-lines and disk-benchmarks.yml. This was intentionally omitted from #1516 because the baseline versions run code from the `main` branch, which did not yet contain the required fixes to enable failures on warnings. Now that #1516 has landed in main, it is safe to enable this for the baseline versions as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1516.
This PR enables
--config "$RUST_CONFIG"for the baseline versions of llvm-lines and disk-benchmarks.yml.This was intentionally omitted from #1516 because the baseline versions run code from the
mainbranch, which did not yet contain the required fixes to enable failures on warnings. Now that #1516 has landed in main, it is safe to enable this for the baseline versions as well.