Repository navigation
[diskann-vector] Neon Squared L2 kernels for int8 and uint8 - #1540
Merged
Harsha Simhadri (harsha-simhadri) merged 4 commits intoOct 30, 2026
Merged
Harsha Simhadri (harsha-simhadri) merged 4 commits into
Harsha Simhadri (harsha-simhadri) merged 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the AArch64 Neon squared-L2 kernel and distance-schema updates.
No open issues 🎉
What changed in this PR
This PR optimizes DiskANN’s AArch64 Neon squared-L2 kernels for signed and unsigned 8-bit vectors, keeping the distance schemas aligned with the updated kernels.
Changes:
- Replaces widening subtraction and multiplication with absolute differences and dot-product accumulation.
- Reduces accumulators from eight lanes to four and updates scalar-tail handling.
- Expands kernel tests with minimum and maximum input and accumulator values.
| File | Description |
|---|---|
diskann-wide/src/arch/aarch64/algorithms.rs |
Updates both Neon kernels and adds boundary-case tests. |
diskann-vector/src/distance/simd.rs |
Adapts Neon L2 schemas and scalar tails to four-lane accumulators. |
Review effort: Balanced
Mark Hildebrand (hildebrandmw)
left a comment
Contributor
There was a problem hiding this comment.
One small request, since we have an opportunity here to delete even more code.
Mark Hildebrand (hildebrandmw)
approved these changes
Oct 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
+ Coverage 91.01% 91.06% +0.04%
==========================================
Files 602 602
Lines 124144 124137 -7
==========================================
+ Hits 112994 113045 +51
+ Misses 11150 11092 -58
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Jack Moffitt (metajack)
approved these changes
Oct 30, 2026
Harsha Simhadri (harsha-simhadri)
merged commit Oct 30, 2026
ffeaa9f
into
microsoft:main
31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes:
Both myself and Utsav Goel have worked on this together.