Repository navigation
[diskann-quantization] Use f32::NAN instead of core::f32::NAN. - #1471
Merged
Mark Hildebrand (hildebrandmw) merged 1 commit intoOct 13, 2026
Merged
Conversation
Mark Hildebrand (hildebrandmw)
requested review from
a team
and
a balanced review from Copilot
October 8, 2026 15:31
Copilot started reviewing on behalf of
Mark Hildebrand (hildebrandmw)
October 8, 2026 15:32
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The import removal resolves the warning while preserving valid references and existing behavior.
0 open findings
What changed in this PR
Resolves a nightly deprecation warning in the min-max quantizer without changing behavior.
Changes:
- Removes
use core::f32sof32::NANresolves to the primitive type’s associated constant.
| File | Description |
|---|---|
diskann-quantization/src/minmax/quantizer.rs |
Removes the import that selects deprecated module constants. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1471 +/- ##
==========================================
- Coverage 91.97% 90.95% -1.03%
==========================================
Files 586 586
Lines 118178 118178
==========================================
- Hits 108700 107490 -1210
- Misses 9478 10688 +1210
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Harsha Simhadri (harsha-simhadri)
approved these changes
Oct 8, 2026
Aditya Krishnan (arkrishn94)
approved these changes
Oct 13, 2026
Mark Hildebrand (hildebrandmw)
deleted the
mhildebr/associated-constant
branch
October 13, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly emits a deprecation warning:
This fixes that.