[diskann-quantization] Teach PQ training to return a BasicTable.

[Mark Hildebrand (hildebrandmw)]

Now that PQ training is starting to be more diskann-quantization centric, it makes sense to return a more useful type.

[Codecov Comments Bot (codecov-commenter)]

Codecov Report

❌ Patch coverage is 92.63158% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.95%. Comparing base (27cdd95) to head (1aa710d).

Files with missing lines	Patch %	Lines
diskann-quantization/src/product/train.rs	87.17%	5 Missing ⚠️
diskann-quantization/src/product/tables/basic.rs	92.59%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1467      +/-   ##
==========================================
- Coverage   91.97%   90.95%   -1.03%     
==========================================
  Files         586      586              
  Lines      118178   118173       -5     
==========================================
- Hits       108700   107485    -1215     
- Misses       9478    10688    +1210     

Flag	Coverage Δ
miri	90.95% <92.63%> (-1.03%)	⬇️
unittests	90.64% <92.47%> (-1.28%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
diskann-benchmark/src/exhaustive/product.rs	77.88% <100.00%> (+0.07%)	⬆️
diskann-providers/src/model/pq/pq_construction.rs	93.90% <100.00%> (-0.03%)	⬇️
diskann-quantization/src/product/tables/padded.rs	95.85% <100.00%> (-0.05%)	⬇️
diskann-quantization/src/views.rs	98.82% <100.00%> (+0.05%)	⬆️
diskann-quantization/src/product/tables/basic.rs	98.40% <92.59%> (-0.98%)	⬇️
diskann-quantization/src/product/train.rs	94.39% <87.17%> (-1.81%)	⬇️

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot review overview

🟢 Approval recommended

The implementation and consumers are consistent; only a non-blocking documentation typo remains.

Review effort: Balanced
Findings: 1

Open (1)

• Grammatically incorrect sentence; use “if” · New

What changed in this PR

Updates PQ training to return a directly usable BasicTable.

Changes:

• Packs trained pivots into BasicTable.
• Adds checked chunk and pivot accessors.
• Simplifies benchmark and provider consumers.

File	Description
diskann-quantization/​src/​views.rs	Adds checked chunk access.
diskann-quantization/​src/​product/​train.rs	Returns packed BasicTable.
diskann-quantization/​src/​product/​tables/​padded.rs	Reuses chunk pivot accessor.
diskann-quantization/​src/​product/​tables/​basic.rs	Adds per-chunk pivot views.
diskann-providers/​src/​model/​pq/​pq_construction.rs	Consumes trained table directly.
diskann-benchmark/​src/​exhaustive/​product.rs	Removes manual table construction.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.