Repository navigation
[diskann-garnet] Support configurable start points and allow importing start points - #1464
Open
Jack Moffitt (metajack) wants to merge 2 commits into
Open
Jack Moffitt (metajack) wants to merge 2 commits into
Jack Moffitt (metajack) wants to merge 2 commits into
Conversation
Jack Moffitt (metajack)
marked this pull request as ready for review
October 6, 2026 19:41
Jack Moffitt (metajack)
added this pull request to stack #1466
October 6, 2026 19:44
Jack Moffitt (metajack)
requested review from
a team
and
a balanced review from Copilot
October 7, 2026 21:27
Jack Moffitt (metajack)
force-pushed
the
push-qtrvttpzkznv
branch
from
October 7, 2026 21:27
cb46d6f to
10b8436
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Import finalization can incorrectly reject valid external IDs that match the start-point ID bytes.
1 open finding
What changed in this PR
Adds configurable Garnet start-point IDs and supports importing start-point terms while excluding them from FSM accounting.
Changes:
- Threads configurable start-point IDs through the FFI and provider.
- Reserves the start-point ID outside the free-space map.
- Adds import validation, tests, documentation, and a major version bump.
| File | Description |
|---|---|
diskann-garnet/src/provider.rs |
Implements configurable and importable start points. |
diskann-garnet/src/fsm.rs |
Excludes the reserved ID from allocation and tracking. |
diskann-garnet/src/lib.rs |
Adds the start-point ID to the FFI. |
diskann-garnet/src/test_utils.rs |
Updates provider test construction. |
diskann-garnet/src/ffi_tests.rs |
Tests configurable and imported start points. |
diskann-garnet/src/ffi_recall_tests.rs |
Updates recall tests for the new FFI. |
diskann-garnet/docs/ffi-design.rs |
Documents the new FFI parameter. |
diskann-garnet/docs/data-design.md |
Documents start-point storage semantics. |
diskann-garnet/Cargo.toml |
Bumps the crate to 7.0.0. |
diskann-garnet/diskann-garnet.nuspec |
Bumps the package to 7.0.0. |
Cargo.lock |
Records the new crate version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| .write_iid(&context.term(Term::Neighbors), 0, &ns) | ||
| { | ||
| return (true, Some(false)); | ||
| for term in [Term::Attributes, Term::ExtMap, Term::IntMap] { |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## push-ttwwvqlmswws #1464 +/- ##
=====================================================
+ Coverage 90.98% 92.04% +1.05%
=====================================================
Files 586 586
Lines 119020 119379 +359
=====================================================
+ Hits 108294 109883 +1589
+ Misses 10726 9496 -1230
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Jack Moffitt (metajack)
force-pushed
the
push-qtrvttpzkznv
branch
from
October 9, 2026 16:25
10b8436 to
626a787
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Iceberg indices set an arbitrary start point id, so Garnet reserving id 0 made index import awkward.
This PR removes the hardcoded use of id 0 for the start point, and removes tracking its state from the FSM. The default start point is now u32::MAX. It also adds the ability for Garnet to control the start point id and import start point terms.