[benchmark-runner] Bump edition to 2024

diskann-benchmark-runner/Cargo.toml

@@ -5,7 +5,7 @@ description.workspace = true
 authors.workspace = true
 repository.workspace = true
 license.workspace = true
-edition.workspace = true
+edition = "2024"
 
 [dependencies]
 anyhow = { workspace = true }

diskann-benchmark-runner/dev/main.rs

@@ -6,7 +6,7 @@
 //! Development CLI for exercising the benchmark runner with its test registry.
 
 use clap::Parser;
-use diskann_benchmark_runner::{output, test, App, Registry};
+use diskann_benchmark_runner::{App, Registry, output, test};
 
 fn main() -> anyhow::Result<()> {
     // Parse the command line options.

diskann-benchmark-runner/src/benchmark.rs

@@ -5,7 +5,7 @@
 
 use serde::{Deserialize, Serialize};
 
-use crate::{internal::visibility::Visibility, Checkpoint, Input, Output};
+use crate::{Checkpoint, Input, Output, internal::visibility::Visibility};
 
 ///////////////
 // Benchmark //
@@ -328,7 +328,7 @@ pub(crate) struct FailureScore(pub(crate) u32);
 pub(crate) mod internal {
     use super::*;
 
-    use crate::{input::internal::Any, Features};
+    use crate::{Features, input::internal::Any};
 
     use anyhow::Context;
     use thiserror::Error;

diskann-benchmark-runner/src/checker.rs

@@ -213,7 +213,7 @@ impl Kind {
 mod tests {
     use super::*;
 
-    use std::fs::{create_dir, File};
+    use std::fs::{File, create_dir};
 
     #[test]
     fn test_constructor() {

diskann-benchmark-runner/src/features.rs

@@ -103,11 +103,7 @@ impl From<&'static str> for Features {
 impl std::fmt::Display for Features {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         fn feature(plural: bool) -> &'static str {
-            if plural {
-                "features"
-            } else {
-                "feature"
-            }
+            if plural { "features" } else { "feature" }
         }
 
         match &self.0 {

diskann-benchmark-runner/src/files.rs

@@ -74,7 +74,7 @@ impl std::fmt::Display for InputFile {
 
 #[cfg(test)]
 mod tests {
-    use std::fs::{create_dir, File};
+    use std::fs::{File, create_dir};
 
     use super::*;
 

diskann-benchmark-runner/src/input.rs

@@ -3,7 +3,7 @@
  * Licensed under the MIT license.
  */
 
-use crate::{internal::visibility::Visibility, Checker};
+use crate::{Checker, internal::visibility::Visibility};
 
 /// Inputs to [`Benchmarks`](crate::Benchmark).
 ///

diskann-benchmark-runner/src/internal/regression.rs

@@ -99,10 +99,11 @@ use serde::{Deserialize, Serialize};
 use serde_json::Value;
 
 use crate::{
-    benchmark::{internal::CheckedPassFail, PassFail},
+    Checker,
+    benchmark::{PassFail, internal::CheckedPassFail},
     input::internal::Any,
     internal::load_from_disk,
-    jobs, registry, result, Checker,
+    jobs, registry, result,
 };
 
 ////////////

diskann-benchmark-runner/src/internal/visibility.rs

@@ -52,10 +52,12 @@ mod tests {
     fn test_is_available() {
         let features = Features::new("some-feature");
         assert!(Visibility::Available.is_available());
-        assert!(!Visibility::Gated {
-            features: &features
-        }
-        .is_available());
+        assert!(
+            !Visibility::Gated {
+                features: &features
+            }
+            .is_available()
+        );
     }
 
     #[test]

diskann-benchmark-runner/src/jobs.rs

@@ -8,7 +8,7 @@ use std::path::{Path, PathBuf};
 use anyhow::Context;
 use serde::{Deserialize, Serialize};
 
-use crate::{checker::Checker, input, Registry};
+use crate::{Registry, checker::Checker, input};
 
 #[derive(Debug)]
 pub(crate) struct Jobs {

diskann-benchmark-runner/src/registry.rs

@@ -3,15 +3,15 @@
  * Licensed under the MIT license.
  */
 
-use std::collections::{hash_map::Entry, HashMap};
+use std::collections::{HashMap, hash_map::Entry};
 
 use thiserror::Error;
 
 use crate::{
-    benchmark::{self, internal::AnnotatedMatch, Benchmark, MatchContext, Regression, Score},
+    Checkpoint, Features, Input, Output,
+    benchmark::{self, Benchmark, MatchContext, Regression, Score, internal::AnnotatedMatch},
     input,
     internal::visibility::Visibility,
-    Checkpoint, Features, Input, Output,
 };
 
 /// A collection of registered inputs and benchmarks.
@@ -609,7 +609,7 @@ pub(crate) struct RegisteredTolerance<'a> {
 mod tests {
     use super::*;
 
-    use crate::{input, Checker};
+    use crate::{Checker, input};
 
     macro_rules! input {
         ($T:ident, $tag:literal) => {

diskann-benchmark-runner/src/result.rs

@@ -7,7 +7,7 @@
 
 use std::path::Path;
 
-use serde::{ser::SerializeSeq, Deserialize, Serialize, Serializer};
+use serde::{Deserialize, Serialize, Serializer, ser::SerializeSeq};
 
 /// A helper to generate incremental snapshots of data while a benchmark is progressing.
 ///

diskann-benchmark-runner/src/test/dim.rs

@@ -8,8 +8,8 @@ use std::io::Write;
 use serde::{Deserialize, Serialize};
 
 use crate::{
-    benchmark::{MatchContext, PassFail, Regression, Score},
     Benchmark, Checker, Checkpoint, Input, Output,
+    benchmark::{MatchContext, PassFail, Regression, Score},
 };
 
 ///////////

diskann-benchmark-runner/src/test/gated.rs

@@ -16,7 +16,7 @@ use std::io::Write;
 use serde::{Deserialize, Serialize};
 
 use crate::{
-    benchmark::MatchContext, benchmark::Score, Benchmark, Checker, Checkpoint, Input, Output,
+    Benchmark, Checker, Checkpoint, Input, Output, benchmark::MatchContext, benchmark::Score,
 };
 
 use super::{dim::DimInput, typed::TypeInput};

diskann-benchmark-runner/src/test/mod.rs

@@ -5,7 +5,7 @@
 
 use std::collections::HashSet;
 
-use crate::{registry, Features};
+use crate::{Features, registry};
 
 mod dim;
 mod gated;

diskann-benchmark-runner/src/test/typed.rs

@@ -8,9 +8,9 @@ use std::io::Write;
 use serde::{Deserialize, Serialize};
 
 use crate::{
+    Benchmark, Checker, Checkpoint, Input, Output,
     benchmark::{MatchContext, PassFail, Regression, Score},
     utils::datatype::{AsDataType, DataType},
-    Benchmark, Checker, Checkpoint, Input, Output,
 };
 
 ///////////

diskann-benchmark-runner/src/ux.rs

@@ -78,10 +78,10 @@ pub fn strip_backtrace(s: String) -> String {
             in_stacktrace = true;
 
             // Remove a previous empty line (if any).
-            if let Some(previous) = lines.last() {
-                if previous.is_empty() {
-                    lines.pop();
-                }
+            if let Some(previous) = lines.last()
+                && previous.is_empty()
+            {
+                lines.pop();
             }
         } else {
             lines.push(line);