[diskann-wide] Fix alias!

[Mark Hildebrand (hildebrandmw)]

#1409 required the use of expect for allowances rather than allow, helping us clean up allowances that no-longer fire. However, this interacted poorly with the diskann_wide::alias! macro, which can have both proper camel-case and non-camel-case types (and thus needs allow). The final version of #1409 put an expect allowance on allow(non_camel_case_type), but this breaks user code outside of DiskANN that may be using different lints.

This PR places an allowance on the macro itself to (1) keep non-DiskANN uses compiling and (2) keep DiskANN uses compiling with the new lints.

Finally, the macro-level allowance does not apply within the diskann-wide crate itself. I made diskann-wide an exception to the allow_attributes lint for this reason.

[Copilot]

🟡 Changes recommended

The public alias! macro documentation currently contains an incorrect example, and the lint exception in diskann-wide/Cargo.toml would be clearer if made explicit.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR adjusts diskann_wide::alias! to avoid emitting #[expect(clippy::allow_attributes)] into downstream crates (which can fail builds depending on the downstream crate’s Clippy lint configuration), while keeping the macro usable for both CamelCase and non-CamelCase aliases.

Changes:

• Add a macro-level #[allow(clippy::allow_attributes)] to prevent the exported macro from forcing downstream lint expectations.
• Remove the per-arm #[expect(clippy::allow_attributes)] wrappers so downstream crates don’t get unfulfilled expect warnings.
• Relax diskann-wide’s local Clippy lint configuration by removing clippy.allow_attributes = "warn" from its Cargo.toml.

File summaries

File	Description
diskann-wide/src/lib.rs	Moves the Clippy allowance to the macro definition and removes emitted #[expect] attributes from macro expansions.
diskann-wide/Cargo.toml	Adjusts crate-local lint configuration related to clippy::allow_attributes.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Codecov Comments Bot (codecov-commenter)]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.66%. Comparing base (8f11bd4) to head (ea4e2bd).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
+ Coverage   91.54%   92.66%   +1.12%     
==========================================
  Files         526      526              
  Lines      103148   103148              
==========================================
+ Hits        94423    95582    +1159     
+ Misses       8725     7566    -1159     

Flag	Coverage Δ
miri	92.66% <ø> (+1.12%)	⬆️
unittests	92.60% <ø> (+1.32%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
diskann-wide/src/lib.rs	53.33% <ø> (-33.34%)	⬇️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.