Repository navigation
Bump toolchain to 1.97.1 - #1340
Merged
Merged
Conversation
Jack Moffitt (metajack)
requested review from
a team
and
a lite review from Copilot
August 17, 2026 20:29
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DiskANN’s Rust toolchain to 1.97.1 and performs the corresponding maintenance updates needed to keep the workspace clean under the new compiler/clippy, including updating the iai-callgrind benchmark dependency and adapting bench configuration to the newer API.
Changes:
- Bump Rust toolchain from 1.95 to 1.97.1.
- Bump
iai-callgrindto 0.16.1 and update IAI benchmark harness/config usage accordingly (including switching tostd::hint::black_box). - Apply clippy-driven cleanups (e.g.,
map.values(),?propagation, removing needless borrows, and trait-qualified associated constants).
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Pins the repo toolchain to Rust 1.97.1. |
| Cargo.toml | Bumps the workspace iai-callgrind dependency to 0.16.1. |
| Cargo.lock | Updates lockfile entries to reflect the iai-callgrind bump and transitive dependency versions. |
| diskann-wide/src/test_utils/distribution.rs | Adjusts float layout constant access to use trait-qualified associated constants (clippy/toolchain compatibility). |
| diskann-vector/benches/benchmarks_iai/cosine_normalized_iai.rs | Switches black_box import to std::hint::black_box. |
| diskann-vector/benches/benchmarks_iai/cosine_iai.rs | Switches black_box import to std::hint::black_box. |
| diskann-vector/benches/benchmarks_iai/contains_bench_iai.rs | Switches black_box import to std::hint::black_box. |
| diskann-vector/benches/bench_main_vector_iai.rs | Updates IAI Callgrind main config to the newer tool-based configuration API. |
| diskann-disk/benches/bench_main_iai.rs | Updates IAI Callgrind main config to the newer tool-based configuration API. |
| diskann-tools/src/utils/compute_bitmap.rs | Minor iteration cleanup using values() when keys aren’t needed. |
| diskann-label-filter/src/parser/query_parser.rs | Simplifies error propagation using ? while preserving behavior. |
| diskann-benchmark/src/inputs/graph_index.rs | Removes a needless borrow in format! for metadata path creation. |
| diskann-quantization/src/minmax/quantizer.rs | Removes unnecessary borrows in test assertion formatting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 92.55% 91.56% -0.99%
==========================================
Files 521 521
Lines 99528 99527 -1
==========================================
- Hits 92114 91128 -986
- Misses 7414 8399 +985
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Harsha Simhadri (harsha-simhadri)
approved these changes
Aug 17, 2026
Mark Hildebrand (hildebrandmw)
approved these changes
Aug 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Rust toolchain to 1.97.1 now that internal Microsoft toolchain are available for the same version.
Aside from the normal few clippy lint changes, this also bumps iai-callgrind to 0.16.1. This was intended to fix a future incompatibility warning, however, but unfortunately did not as the root cause is the unmaintained proc-macro-error2 crate which is still a dependency of iai-callgrind 0.16.1.