Skip to content

Bump toolchain to 1.97.1 - #1340

Merged
Mark Hildebrand (hildebrandmw) merged 1 commit into
mainfrom
push-puvmywwywsvs
Aug 17, 2026
Merged

Mark Hildebrand (hildebrandmw) merged 1 commit into
mainfrom
push-puvmywwywsvs

Conversation

@metajack

Copy link
Copy Markdown
Contributor

This updates the Rust toolchain to 1.97.1 now that internal Microsoft toolchain are available for the same version.

Aside from the normal few clippy lint changes, this also bumps iai-callgrind to 0.16.1. This was intended to fix a future incompatibility warning, however, but unfortunately did not as the root cause is the unmaintained proc-macro-error2 crate which is still a dependency of iai-callgrind 0.16.1.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates DiskANN’s Rust toolchain to 1.97.1 and performs the corresponding maintenance updates needed to keep the workspace clean under the new compiler/clippy, including updating the iai-callgrind benchmark dependency and adapting bench configuration to the newer API.

Changes:

  • Bump Rust toolchain from 1.95 to 1.97.1.
  • Bump iai-callgrind to 0.16.1 and update IAI benchmark harness/config usage accordingly (including switching to std::hint::black_box).
  • Apply clippy-driven cleanups (e.g., map.values(), ? propagation, removing needless borrows, and trait-qualified associated constants).

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rust-toolchain.toml Pins the repo toolchain to Rust 1.97.1.
Cargo.toml Bumps the workspace iai-callgrind dependency to 0.16.1.
Cargo.lock Updates lockfile entries to reflect the iai-callgrind bump and transitive dependency versions.
diskann-wide/src/test_utils/distribution.rs Adjusts float layout constant access to use trait-qualified associated constants (clippy/toolchain compatibility).
diskann-vector/benches/benchmarks_iai/cosine_normalized_iai.rs Switches black_box import to std::hint::black_box.
diskann-vector/benches/benchmarks_iai/cosine_iai.rs Switches black_box import to std::hint::black_box.
diskann-vector/benches/benchmarks_iai/contains_bench_iai.rs Switches black_box import to std::hint::black_box.
diskann-vector/benches/bench_main_vector_iai.rs Updates IAI Callgrind main config to the newer tool-based configuration API.
diskann-disk/benches/bench_main_iai.rs Updates IAI Callgrind main config to the newer tool-based configuration API.
diskann-tools/src/utils/compute_bitmap.rs Minor iteration cleanup using values() when keys aren’t needed.
diskann-label-filter/src/parser/query_parser.rs Simplifies error propagation using ? while preserving behavior.
diskann-benchmark/src/inputs/graph_index.rs Removes a needless borrow in format! for metadata path creation.
diskann-quantization/src/minmax/quantizer.rs Removes unnecessary borrows in test assertion formatting.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (e0b0b81) to head (2e29924).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   92.55%   91.56%   -0.99%     
==========================================
  Files         521      521              
  Lines       99528    99527       -1     
==========================================
- Hits        92114    91128     -986     
- Misses       7414     8399     +985     
Flag Coverage Δ
miri 91.56% <100.00%> (-0.99%) ⬇️
unittests 91.24% <100.00%> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diskann-benchmark/src/inputs/graph_index.rs 58.98% <100.00%> (ø)
diskann-label-filter/src/parser/query_parser.rs 74.63% <100.00%> (-0.13%) ⬇️
diskann-quantization/src/minmax/quantizer.rs 96.02% <ø> (+0.75%) ⬆️
diskann-tools/src/utils/compute_bitmap.rs 94.24% <100.00%> (ø)
diskann-wide/src/test_utils/distribution.rs 100.00% <100.00%> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hildebrandmw
Mark Hildebrand (hildebrandmw) merged commit 45819de into main Aug 17, 2026
32 checks passed
@hildebrandmw
Mark Hildebrand (hildebrandmw) deleted the push-puvmywwywsvs branch August 17, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants