Skip to content

Remember when the setup picker is dismissed - #115

Open
Minh Vu (fallintoplace) wants to merge 1 commit into
microsoft:mainfrom
fallintoplace:fix/remember-dismissed-picker
Open

Remember when the setup picker is dismissed#115
Minh Vu (fallintoplace) wants to merge 1 commit into
microsoft:mainfrom
fallintoplace:fix/remember-dismissed-picker

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • remember when the first-run setup picker is dismissed without a selection
  • distinguish dismissal from the existing accepted flow
  • keep manual setup available through the Command Palette
  • document the updated first-run behavior

Testing

  • npm run check-types
  • npm run lint
  • npm test (96 passing)

@ozzafar Oz Zafar (ozzafar) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dismissal state is recorded correctly without affecting accepted selections, and manual setup remains available. I validated the merge result against current main; compile, lint, and all 136 tests pass. A focused QuickPick dismissal test would be useful follow-up coverage, but I do not consider it merge-blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants