Skip to content

reproducible Joint rpca mia gemelli comparison - #834

Closed
sabujcb wants to merge 11 commits into
microbiome:develfrom
sabujcb:joint-rpca-mia-gemelli-comparison
Closed

reproducible Joint rpca mia gemelli comparison #834
sabujcb wants to merge 11 commits into
microbiome:develfrom
sabujcb:joint-rpca-mia-gemelli-comparison

Conversation

@sabujcb

@sabujcb sabujcb commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@TuomasBorman

Copy link
Copy Markdown
Contributor

The intention of these vignettes seem to be more testing, not educational purpose. However, I think these are valuable resources, but might not be best suited for package vignettes. benchmarking repo (or if we create "workflows" repo) could be more suited for these.

Comment thread vignettes/joint-rpca-mia-gemelli-setup.md
Comment thread vignettes/joint-rpca-mia-gemelli-setup.md
Comment thread vignettes/joint-rpca-mia-gemelli-setup.md
Comment thread vignettes/joint-rpca-mia-gemelli-setup.md
@antagomir
antagomir requested a review from TuomasBorman August 1, 2026 13:47
@antagomir

Copy link
Copy Markdown
Member

The vignette related comments I trust @sabujcb will handle while moving the workflow.

@TuomasBorman this now ok to merge? (merge blocked until your ok)

@TuomasBorman

Copy link
Copy Markdown
Contributor

Move files to https://github.com/microbiome/OMAWorkflows

They can be directly merged.

One thing to note: Your vignette is in quarto format, which is good. But the rendering engine must be changed: https://contributions.bioconductor.org/docs.html?q=vignette#quarto-vignettes

@TuomasBorman

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants