-
-
Notifications
You must be signed in to change notification settings - Fork 32
Fix duplicate dmix ipc_key collisions in asound.conf #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveMicroNova
merged 1 commit into
micro-nova:main
from
stamateviorel:fix/asound-unique-dmix-ipc-keys
Jun 25, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,6 +71,7 @@ pcm.dmixer { | |
| period_size 1024 | ||
| buffer_size 4096 | ||
| channels 8 | ||
| rate 48000 | ||
| } | ||
| bindings { | ||
| 0 0 | ||
|
|
@@ -249,7 +250,7 @@ pcm.lb0c { | |
| } | ||
| pcm.lb1 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1029 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice catch! |
||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_1,0" | ||
|
|
@@ -266,7 +267,7 @@ pcm.lb1c { | |
|
|
||
| pcm.lb2 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1030 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_2,0" | ||
|
|
@@ -282,7 +283,7 @@ pcm.lb2c { | |
| } | ||
| pcm.lb3 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1031 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_3,0" | ||
|
|
@@ -298,7 +299,7 @@ pcm.lb3c { | |
| } | ||
| pcm.lb4 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1032 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_4,0" | ||
|
|
@@ -314,7 +315,7 @@ pcm.lb4c { | |
| } | ||
| pcm.lb5 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1033 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_5,0" | ||
|
|
@@ -332,7 +333,7 @@ pcm.lb5c { | |
|
|
||
| pcm.lb6 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1034 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback,1" | ||
|
|
@@ -348,7 +349,7 @@ pcm.lb6c { | |
| } | ||
| pcm.lb7 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1035 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_1,1" | ||
|
|
@@ -365,7 +366,7 @@ pcm.lb7c { | |
|
|
||
| pcm.lb8 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1036 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_2,1" | ||
|
|
@@ -381,7 +382,7 @@ pcm.lb8c { | |
| } | ||
| pcm.lb9 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1037 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_3,1" | ||
|
|
@@ -397,7 +398,7 @@ pcm.lb9c { | |
| } | ||
| pcm.lb10 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1038 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_4,1" | ||
|
|
@@ -413,7 +414,7 @@ pcm.lb10c { | |
| } | ||
| pcm.lb11 { | ||
| type dmix | ||
| ipc_key 1028 | ||
| ipc_key 1039 | ||
| ipc_perm 0666 | ||
| slave { | ||
| pcm "hw:Loopback_5,1" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is setting this fixed rate required? I know this is the default rate of the device but I'm not sure what the implications of fixing this rate rate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly required, and happy to drop it. It's defensive rather than a fix: without an explicit rate, the first client to open the dmix sets the slave rate for every other loopback, so a stream that opens at 44100 would reconfigure the shared buffer and force resampling on everything else. Pinning it to 48000 (the DAC's native rate, which is also dmix's default here) just makes that explicit so no single client can move it.
That said, it's a separate concern from the ipc_key collision this PR is really about. If you'd rather keep the change minimal, I'll pull the
rateline out and leave just the unique-key fix.